opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-08-01 03:21:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Tests: use t.Setenv to set env vars (#69516)

Browse Source 
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.Setenv

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit is contained in:
Eng Zer Jun
2023-06-05 17:31:03 +08:00
committed by GitHub
parent 4c794fe8b9
commit cf1945d0c3
13 changed files with 35 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/services/provisioning/plugins/config_reader_test.go
View File

@ -2,7 +2,6 @@ package plugins
import (
"context"
"os"
"testing"
"github.com/stretchr/testify/require"
@ -55,11 +54,7 @@ func TestConfigReader(t *testing.T) {
},
}
err := os.Setenv("ENABLE_PLUGIN_VAR", "test-plugin")
require.NoError(t, err)
t.Cleanup(func() {
_ = os.Unsetenv("ENABLE_PLUGIN_VAR")
})
t.Setenv("ENABLE_PLUGIN_VAR", "test-plugin")
cfgProvider := newConfigReader(log.New("test logger"), pm)
cfg, err := cfgProvider.readConfig(context.Background(), correctProperties)