Tests: use t.Setenv to set env vars (#69516)

This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.Setenv

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit is contained in:
Eng Zer Jun
2023-06-05 17:31:03 +08:00
committed by GitHub
parent 4c794fe8b9
commit cf1945d0c3
13 changed files with 35 additions and 98 deletions

View File

@ -1,7 +1,6 @@
package tracing
import (
"os"
"testing"
"github.com/stretchr/testify/assert"
@ -141,13 +140,8 @@ func TestTracingConfig(t *testing.T) {
// export envioronment variables
if test.Env != nil {
for k, v := range test.Env {
assert.NoError(t, os.Setenv(k, v))
t.Setenv(k, v)
}
defer func() {
for k := range test.Env {
assert.NoError(t, os.Unsetenv(k))
}
}()
}
// parse config sections
cfg := setting.NewCfg()