opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-07-31 06:52:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Tests: use t.Setenv to set env vars (#69516)

Browse Source 
This commit replaces `os.Setenv` with `t.Setenv` in tests. The
environment variable is automatically restored to its original value
when the test and all its subtests complete.

Reference: https://pkg.go.dev/testing#T.Setenv

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit is contained in:
Eng Zer Jun
2023-06-05 17:31:03 +08:00
committed by GitHub
parent 4c794fe8b9
commit cf1945d0c3
13 changed files with 35 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
pkg/cmd/grafana-server/commands/diagnostics_test.go
View File

@ -2,7 +2,6 @@ package commands
import (
"fmt"
"os"
"testing"
"github.com/stretchr/testify/assert"
@ -25,18 +24,14 @@ func TestProfilingDiagnostics(t *testing.T) {
for i, tc := range tcs {
t.Run(fmt.Sprintf("testcase %d", i), func(t *testing.T) {
os.Clearenv()
if tc.enabledEnv != "" {
err := os.Setenv(profilingEnabledEnvName, tc.enabledEnv)
assert.NoError(t, err)
t.Setenv(profilingEnabledEnvName, tc.enabledEnv)
}
if tc.addrEnv != "" {
err := os.Setenv(profilingAddrEnvName, tc.addrEnv)
assert.NoError(t, err)
t.Setenv(profilingAddrEnvName, tc.addrEnv)
}
if tc.portEnv != "" {
err := os.Setenv(profilingPortEnvName, tc.portEnv)
assert.NoError(t, err)
t.Setenv(profilingPortEnvName, tc.portEnv)
}
err := tc.defaults.overrideWithEnv()
assert.NoError(t, err)
@ -61,14 +56,11 @@ func TestTracingDiagnostics(t *testing.T) {
for i, tc := range tcs {
t.Run(fmt.Sprintf("testcase %d", i), func(t *testing.T) {
os.Clearenv()
if tc.enabledEnv != "" {
err := os.Setenv(tracingEnabledEnvName, tc.enabledEnv)
assert.NoError(t, err)
t.Setenv(tracingEnabledEnvName, tc.enabledEnv)
}
if tc.fileEnv != "" {
err := os.Setenv(tracingFileEnvName, tc.fileEnv)
assert.NoError(t, err)
t.Setenv(tracingFileEnvName, tc.fileEnv)
}
err := tc.defaults.overrideWithEnv()
assert.NoError(t, err)