opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-07-30 23:52:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Rewrite opentsdb test to standard library (#29792)

Browse Source
This commit is contained in:
Emil Hessman
2020-12-14 09:33:25 +01:00
committed by GitHub
parent 2b5a88bf8c
commit cedaf41a36
1 changed files with 134 additions and 127 deletions
Download Patch File Download Diff File Expand all files Collapse all files

261
pkg/tsdb/opentsdb/opentsdb_test.go
View File

@ -5,162 +5,169 @@ import (
"github.com/grafana/grafana/pkg/components/simplejson" "github.com/grafana/grafana/pkg/components/simplejson"
"github.com/grafana/grafana/pkg/tsdb" "github.com/grafana/grafana/pkg/tsdb"
. "github.com/smartystreets/goconvey/convey" "github.com/stretchr/testify/require"
) )
func TestOpenTsdbExecutor(t *testing.T) { func TestOpenTsdbExecutor(t *testing.T) {
Convey("OpenTsdb query testing", t, func() { exec := &OpenTsdbExecutor{}
exec := &OpenTsdbExecutor{}
Convey("Build metric with downsampling enabled", func() { t.Run("Build metric with downsampling enabled", func(t *testing.T) {
query := &tsdb.Query{ query := &tsdb.Query{
Model: simplejson.New(), Model: simplejson.New(),
} }
query.Model.Set("metric", "cpu.average.percent") query.Model.Set("metric", "cpu.average.percent")
query.Model.Set("aggregator", "avg") query.Model.Set("aggregator", "avg")
query.Model.Set("disableDownsampling", false) query.Model.Set("disableDownsampling", false)
query.Model.Set("downsampleInterval", "") query.Model.Set("downsampleInterval", "")
query.Model.Set("downsampleAggregator", "avg") query.Model.Set("downsampleAggregator", "avg")
query.Model.Set("downsampleFillPolicy", "none") query.Model.Set("downsampleFillPolicy", "none")
metric := exec.buildMetric(query) metric := exec.buildMetric(query)
So(len(metric), ShouldEqual, 3) require.Len(t, metric, 3)
So(metric["metric"], ShouldEqual, "cpu.average.percent") require.Equal(t, "cpu.average.percent", metric["metric"])
So(metric["aggregator"], ShouldEqual, "avg") require.Equal(t, "avg", metric["aggregator"])
So(metric["downsample"], ShouldEqual, "1m-avg") require.Equal(t, "1m-avg", metric["downsample"])
}) })
Convey("Build metric with downsampling disabled", func() { t.Run("Build metric with downsampling disabled", func(t *testing.T) {
query := &tsdb.Query{ query := &tsdb.Query{
Model: simplejson.New(), Model: simplejson.New(),
} }
query.Model.Set("metric", "cpu.average.percent") query.Model.Set("metric", "cpu.average.percent")
query.Model.Set("aggregator", "avg") query.Model.Set("aggregator", "avg")
query.Model.Set("disableDownsampling", true) query.Model.Set("disableDownsampling", true)
query.Model.Set("downsampleInterval", "") query.Model.Set("downsampleInterval", "")
query.Model.Set("downsampleAggregator", "avg") query.Model.Set("downsampleAggregator", "avg")
query.Model.Set("downsampleFillPolicy", "none") query.Model.Set("downsampleFillPolicy", "none")
metric := exec.buildMetric(query) metric := exec.buildMetric(query)
So(len(metric), ShouldEqual, 2) require.Len(t, metric, 2)
So(metric["metric"], ShouldEqual, "cpu.average.percent") require.Equal(t, "cpu.average.percent", metric["metric"])
So(metric["aggregator"], ShouldEqual, "avg") require.Equal(t, "avg", metric["aggregator"])
}) })
Convey("Build metric with downsampling enabled with params", func() { t.Run("Build metric with downsampling enabled with params", func(t *testing.T) {
query := &tsdb.Query{ query := &tsdb.Query{
Model: simplejson.New(), Model: simplejson.New(),
} }
query.Model.Set("metric", "cpu.average.percent") query.Model.Set("metric", "cpu.average.percent")
query.Model.Set("aggregator", "avg") query.Model.Set("aggregator", "avg")
query.Model.Set("disableDownsampling", false) query.Model.Set("disableDownsampling", false)
query.Model.Set("downsampleInterval", "5m") query.Model.Set("downsampleInterval", "5m")
query.Model.Set("downsampleAggregator", "sum") query.Model.Set("downsampleAggregator", "sum")
query.Model.Set("downsampleFillPolicy", "null") query.Model.Set("downsampleFillPolicy", "null")
metric := exec.buildMetric(query) metric := exec.buildMetric(query)
So(len(metric), ShouldEqual, 3) require.Len(t, metric, 3)
So(metric["metric"], ShouldEqual, "cpu.average.percent") require.Equal(t, "cpu.average.percent", metric["metric"])
So(metric["aggregator"], ShouldEqual, "avg") require.Equal(t, "avg", metric["aggregator"])
So(metric["downsample"], ShouldEqual, "5m-sum-null") require.Equal(t, "5m-sum-null", metric["downsample"])
}) })
Convey("Build metric with tags with downsampling disabled", func() { t.Run("Build metric with tags with downsampling disabled", func(t *testing.T) {
query := &tsdb.Query{ query := &tsdb.Query{
Model: simplejson.New(), Model: simplejson.New(),
} }
query.Model.Set("metric", "cpu.average.percent") query.Model.Set("metric", "cpu.average.percent")
query.Model.Set("aggregator", "avg") query.Model.Set("aggregator", "avg")
query.Model.Set("disableDownsampling", true) query.Model.Set("disableDownsampling", true)
query.Model.Set("downsampleInterval", "5m") query.Model.Set("downsampleInterval", "5m")
query.Model.Set("downsampleAggregator", "sum") query.Model.Set("downsampleAggregator", "sum")
query.Model.Set("downsampleFillPolicy", "null") query.Model.Set("downsampleFillPolicy", "null")
tags := simplejson.New() tags := simplejson.New()
tags.Set("env", "prod") tags.Set("env", "prod")
tags.Set("app", "grafana") tags.Set("app", "grafana")
query.Model.Set("tags", tags.MustMap()) query.Model.Set("tags", tags.MustMap())
metric := exec.buildMetric(query) metric := exec.buildMetric(query)
So(len(metric), ShouldEqual, 3) require.Len(t, metric, 3)
So(metric["metric"], ShouldEqual, "cpu.average.percent") require.Equal(t, "cpu.average.percent", metric["metric"])
So(metric["aggregator"], ShouldEqual, "avg") require.Equal(t, "avg", metric["aggregator"])
So(metric["downsample"], ShouldEqual, nil) require.Nil(t, metric["downsample"])
So(len(metric["tags"].(map[string]interface{})), ShouldEqual, 2)
So(metric["tags"].(map[string]interface{})["env"], ShouldEqual, "prod")
So(metric["tags"].(map[string]interface{})["app"], ShouldEqual, "grafana")
So(metric["tags"].(map[string]interface{})["ip"], ShouldEqual, nil)
})
Convey("Build metric with rate enabled but counter disabled", func() { metricTags := metric["tags"].(map[string]interface{})
query := &tsdb.Query{ require.Len(t, metricTags, 2)
Model: simplejson.New(), require.Equal(t, "prod", metricTags["env"])
} require.Equal(t, "grafana", metricTags["app"])
require.Nil(t, metricTags["ip"])
})
query.Model.Set("metric", "cpu.average.percent") t.Run("Build metric with rate enabled but counter disabled", func(t *testing.T) {
query.Model.Set("aggregator", "avg") query := &tsdb.Query{
query.Model.Set("disableDownsampling", true) Model: simplejson.New(),
query.Model.Set("shouldComputeRate", true) }
query.Model.Set("isCounter", false)
tags := simplejson.New() query.Model.Set("metric", "cpu.average.percent")
tags.Set("env", "prod") query.Model.Set("aggregator", "avg")
tags.Set("app", "grafana") query.Model.Set("disableDownsampling", true)
query.Model.Set("tags", tags.MustMap()) query.Model.Set("shouldComputeRate", true)
query.Model.Set("isCounter", false)
metric := exec.buildMetric(query) tags := simplejson.New()
tags.Set("env", "prod")
tags.Set("app", "grafana")
query.Model.Set("tags", tags.MustMap())
So(len(metric), ShouldEqual, 5) metric := exec.buildMetric(query)
So(metric["metric"], ShouldEqual, "cpu.average.percent")
So(metric["aggregator"], ShouldEqual, "avg")
So(len(metric["tags"].(map[string]interface{})), ShouldEqual, 2)
So(metric["tags"].(map[string]interface{})["env"], ShouldEqual, "prod")
So(metric["tags"].(map[string]interface{})["app"], ShouldEqual, "grafana")
So(metric["tags"].(map[string]interface{})["ip"], ShouldEqual, nil)
So(metric["rate"], ShouldEqual, true)
So(metric["rateOptions"].(map[string]interface{})["counter"], ShouldEqual, false)
})
Convey("Build metric with rate and counter enabled", func() { require.Len(t, metric, 5)
query := &tsdb.Query{ require.Equal(t, "cpu.average.percent", metric["metric"])
Model: simplejson.New(), require.Equal(t, "avg", metric["aggregator"])
}
query.Model.Set("metric", "cpu.average.percent") metricTags := metric["tags"].(map[string]interface{})
query.Model.Set("aggregator", "avg") require.Len(t, metricTags, 2)
query.Model.Set("disableDownsampling", true) require.Equal(t, "prod", metricTags["env"])
query.Model.Set("shouldComputeRate", true) require.Equal(t, "grafana", metricTags["app"])
query.Model.Set("isCounter", true) require.Nil(t, metricTags["ip"])
query.Model.Set("counterMax", 45)
query.Model.Set("counterResetValue", 60)
tags := simplejson.New() require.True(t, metric["rate"].(bool))
tags.Set("env", "prod") require.False(t, metric["rateOptions"].(map[string]interface{})["counter"].(bool))
tags.Set("app", "grafana") })
query.Model.Set("tags", tags.MustMap())
metric := exec.buildMetric(query) t.Run("Build metric with rate and counter enabled", func(t *testing.T) {
query := &tsdb.Query{
Model: simplejson.New(),
}
So(len(metric), ShouldEqual, 5) query.Model.Set("metric", "cpu.average.percent")
So(metric["metric"], ShouldEqual, "cpu.average.percent") query.Model.Set("aggregator", "avg")
So(metric["aggregator"], ShouldEqual, "avg") query.Model.Set("disableDownsampling", true)
So(len(metric["tags"].(map[string]interface{})), ShouldEqual, 2) query.Model.Set("shouldComputeRate", true)
So(metric["tags"].(map[string]interface{})["env"], ShouldEqual, "prod") query.Model.Set("isCounter", true)
So(metric["tags"].(map[string]interface{})["app"], ShouldEqual, "grafana") query.Model.Set("counterMax", 45)
So(metric["tags"].(map[string]interface{})["ip"], ShouldEqual, nil) query.Model.Set("counterResetValue", 60)
So(metric["rate"], ShouldEqual, true)
So(len(metric["rateOptions"].(map[string]interface{})), ShouldEqual, 3) tags := simplejson.New()
So(metric["rateOptions"].(map[string]interface{})["counter"], ShouldEqual, true) tags.Set("env", "prod")
So(metric["rateOptions"].(map[string]interface{})["counterMax"], ShouldEqual, 45) tags.Set("app", "grafana")
So(metric["rateOptions"].(map[string]interface{})["resetValue"], ShouldEqual, 60) query.Model.Set("tags", tags.MustMap())
})
metric := exec.buildMetric(query)
require.Len(t, metric, 5)
require.Equal(t, "cpu.average.percent", metric["metric"])
require.Equal(t, "avg", metric["aggregator"])
metricTags := metric["tags"].(map[string]interface{})
require.Len(t, metricTags, 2)
require.Equal(t, "prod", metricTags["env"])
require.Equal(t, "grafana", metricTags["app"])
require.Nil(t, metricTags["ip"])
require.True(t, metric["rate"].(bool))
metricRateOptions := metric["rateOptions"].(map[string]interface{})
require.Len(t, metricRateOptions, 3)
require.True(t, metricRateOptions["counter"].(bool))
require.Equal(t, float64(45), metricRateOptions["counterMax"])
require.Equal(t, float64(60), metricRateOptions["resetValue"])
}) })
} }