Reduce re-renderings when changing view modes

This commit is contained in:
Torkel Ödegaard
2018-10-27 16:54:04 +02:00
parent 10e5d725bc
commit c5f9d8092f
2 changed files with 11 additions and 7 deletions

View File

@ -21,15 +21,14 @@ function GridWrapper({
className, className,
isResizable, isResizable,
isDraggable, isDraggable,
isFullscreen,
}) { }) {
if (size.width === 0) {
console.log('size is zero!');
}
const width = size.width > 0 ? size.width : lastGridWidth; const width = size.width > 0 ? size.width : lastGridWidth;
if (width !== lastGridWidth) { if (width !== lastGridWidth) {
onWidthChange(); if (!isFullscreen && Math.abs(width - lastGridWidth) > 8) {
lastGridWidth = width; onWidthChange();
lastGridWidth = width;
}
} }
return ( return (
@ -197,6 +196,7 @@ export class DashboardGrid extends React.Component<DashboardGridProps, any> {
onDragStop={this.onDragStop} onDragStop={this.onDragStop}
onResize={this.onResize} onResize={this.onResize}
onResizeStop={this.onResizeStop} onResizeStop={this.onResizeStop}
isFullscreen={this.props.dashboard.meta.fullscreen}
> >
{this.renderPanels()} {this.renderPanels()}
</SizedReactLayoutGrid> </SizedReactLayoutGrid>

View File

@ -36,7 +36,11 @@ export class Graph2 extends PureComponent<Props> {
export class TextOptions extends PureComponent<any> { export class TextOptions extends PureComponent<any> {
render() { render() {
return <p>Text2 Options component</p>; return (
<div className="section gf-form-group">
<h5 className="section-heading">Draw Modes</h5>
</div>
);
} }
} }