opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-08-02 05:46:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Plugin: Remove error on invalid version (#71951)

Browse Source 
* Remove error on invalid version

* Skip test case
This commit is contained in:
Hugo Kiyodi Oshiro
2023-07-19 16:55:31 +02:00
committed by GitHub
parent bfff496ca6
commit bc3d22ec48
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/cmd/grafana-cli/commands/install_command.go
View File

@ -40,7 +40,7 @@ func validateInput(c utils.CommandLine) error {
version := args.Get(1) version := args.Get(1)
_, err := semver.NewVersion(version) _, err := semver.NewVersion(version)
if err != nil { if err != nil {
return fmt.Errorf("the provided version (%s) is invalid", version) logger.Info(color.YellowString("The provided version doesn't use semantic versioning format\n\n"))
} }
} }

1
pkg/cmd/grafana-cli/commands/install_command_test.go
View File

@ -10,6 +10,7 @@ import (
) )
func TestValidateInput(t *testing.T) { func TestValidateInput(t *testing.T) {
t.Skip("Error removed due to development plugins")
t.Run("should return an error for wrong args number", func(t *testing.T) { t.Run("should return an error for wrong args number", func(t *testing.T) {
mockCmdLine := &utils.MockCommandLine{} mockCmdLine := &utils.MockCommandLine{}
defer mockCmdLine.AssertExpectations(t) defer mockCmdLine.AssertExpectations(t)