opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-08-01 15:42:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Perfomance: add preallocation for some slices (#59263)

Browse Source 
add preallocation for some slices
This commit is contained in:
Denis Limarev
2022-11-28 18:10:24 +06:00
committed by GitHub
parent 254577ba56
commit b814c66c1d
8 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/api/dashboard_permission.go
View File

@ -156,7 +156,7 @@ func (hs *HTTPServer) UpdateDashboardPermissions(c *models.ReqContext) response.
return dashboardGuardianResponse(err) return dashboardGuardianResponse(err)
} }
var items []*models.DashboardACL items := make([]*models.DashboardACL, 0, len(apiCmd.Items))
for _, item := range apiCmd.Items { for _, item := range apiCmd.Items {
items = append(items, &models.DashboardACL{ items = append(items, &models.DashboardACL{
OrgID: c.OrgID, OrgID: c.OrgID,

2
pkg/api/folder_permission.go
View File

@ -105,7 +105,7 @@ func (hs *HTTPServer) UpdateFolderPermissions(c *models.ReqContext) response.Res
return apierrors.ToFolderErrorResponse(dashboards.ErrFolderAccessDenied) return apierrors.ToFolderErrorResponse(dashboards.ErrFolderAccessDenied)
} }
var items []*models.DashboardACL items := make([]*models.DashboardACL, 0, len(apiCmd.Items))
for _, item := range apiCmd.Items { for _, item := range apiCmd.Items {
items = append(items, &models.DashboardACL{ items = append(items, &models.DashboardACL{
OrgID: c.OrgID, OrgID: c.OrgID,

2
pkg/codegen/jenny_tsveneerindex.go
View File

@ -306,7 +306,7 @@ var allowedTSVeneers = map[string]bool{
} }
func allowedTSVeneersString() string { func allowedTSVeneersString() string {
var list []string list := make([]string, 0, len(allowedTSVeneers))
for tgt := range allowedTSVeneers { for tgt := range allowedTSVeneers {
list = append(list, tgt) list = append(list, tgt)
} }

2
pkg/plugins/pfs/pfs.go
View File

@ -49,7 +49,7 @@ type slotandname struct {
var allslots []slotandname var allslots []slotandname
func init() { func init() {
var all []string all := make([]string, 0, len(PermittedCUEImports()))
for _, im := range PermittedCUEImports() { for _, im := range PermittedCUEImports() {
all = append(all, fmt.Sprintf("\t%s", im)) all = append(all, fmt.Sprintf("\t%s", im))
} }

2
pkg/plugins/storage/fs.go
View File

@ -55,7 +55,7 @@ func (fs *FS) Add(ctx context.Context, pluginID string, pluginArchive *zip.ReadC
fs.log.Successf("Downloaded and extracted %s v%s zip successfully to %s", res.ID, res.Info.Version, pluginDir) fs.log.Successf("Downloaded and extracted %s v%s zip successfully to %s", res.ID, res.Info.Version, pluginDir)
var deps []*Dependency deps := make([]*Dependency, 0, len(res.Dependencies.Plugins))
for _, plugin := range res.Dependencies.Plugins { for _, plugin := range res.Dependencies.Plugins {
deps = append(deps, &Dependency{ deps = append(deps, &Dependency{
ID: plugin.ID, ID: plugin.ID,

4
pkg/services/accesscontrol/evaluator.go
View File

@ -124,7 +124,7 @@ func (a allEvaluator) Evaluate(permissions map[string][]string) bool {
} }
func (a allEvaluator) MutateScopes(ctx context.Context, mutate ScopeAttributeMutator) (Evaluator, error) { func (a allEvaluator) MutateScopes(ctx context.Context, mutate ScopeAttributeMutator) (Evaluator, error) {
var modified []Evaluator modified := make([]Evaluator, 0, len(a.allOf))
for _, e := range a.allOf { for _, e := range a.allOf {
i, err := e.MutateScopes(ctx, mutate) i, err := e.MutateScopes(ctx, mutate)
if err != nil { if err != nil {
@ -174,7 +174,7 @@ func (a anyEvaluator) Evaluate(permissions map[string][]string) bool {
} }
func (a anyEvaluator) MutateScopes(ctx context.Context, mutate ScopeAttributeMutator) (Evaluator, error) { func (a anyEvaluator) MutateScopes(ctx context.Context, mutate ScopeAttributeMutator) (Evaluator, error) {
var modified []Evaluator modified := make([]Evaluator, 0, len(a.anyOf))
for _, e := range a.anyOf { for _, e := range a.anyOf {
i, err := e.MutateScopes(ctx, mutate) i, err := e.MutateScopes(ctx, mutate)
if err != nil { if err != nil {

2
pkg/services/accesscontrol/resourcepermissions/service.go
View File

@ -53,7 +53,7 @@ func New(
ac accesscontrol.AccessControl, service accesscontrol.Service, sqlStore db.DB, ac accesscontrol.AccessControl, service accesscontrol.Service, sqlStore db.DB,
teamService team.Service, userService user.Service, teamService team.Service, userService user.Service,
) (*Service, error) { ) (*Service, error) {
var permissions []string permissions := make([]string, 0, len(options.PermissionsToActions))
actionSet := make(map[string]struct{}) actionSet := make(map[string]struct{})
for permission, actions := range options.PermissionsToActions { for permission, actions := range options.PermissionsToActions {
permissions = append(permissions, permission) permissions = append(permissions, permission)

2
pkg/services/accesscontrol/resourcepermissions/store.go
View File

@ -608,7 +608,7 @@ func (s *store) createPermissions(sess *db.Session, roleID int64, resource, reso
if len(actions) == 0 { if len(actions) == 0 {
return nil return nil
} }
var permissions []accesscontrol.Permission permissions := make([]accesscontrol.Permission, 0, len(actions))
for action := range actions { for action := range actions {
p := managedPermission(action, resource, resourceID, resourceAttribute) p := managedPermission(action, resource, resourceID, resourceAttribute)
p.RoleID = roleID p.RoleID = roleID