opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-07-29 22:57:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Codestyle: Fix some goconst issues (#17530)

Browse Source 
Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
This commit is contained in:
Mario Trangoni
2019-06-12 07:27:47 +02:00
committed by Carl Bergquist
parent 39e23ba672
commit ab4e1526b3
3 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
pkg/setting/setting_test.go
View File

@ -1,16 +1,21 @@
package setting
import (
"gopkg.in/ini.v1"
"os"
"path"
"path/filepath"
"runtime"
"testing"
"gopkg.in/ini.v1"
. "github.com/smartystreets/goconvey/convey"
)
const (
windows = "windows"
)
func TestLoadingSettings(t *testing.T) {
Convey("Testing loading settings from ini file", t, func() {
@ -72,7 +77,7 @@ func TestLoadingSettings(t *testing.T) {
})
Convey("Should be able to override via command line", func() {
if runtime.GOOS == "windows" {
if runtime.GOOS == windows {
cfg := NewCfg()
cfg.Load(&CommandLineArgs{
HomePath: "../../",
@ -106,7 +111,7 @@ func TestLoadingSettings(t *testing.T) {
})
Convey("Defaults can be overridden in specified config file", func() {
if runtime.GOOS == "windows" {
if runtime.GOOS == windows {
cfg := NewCfg()
cfg.Load(&CommandLineArgs{
HomePath: "../../",
@ -128,7 +133,7 @@ func TestLoadingSettings(t *testing.T) {
})
Convey("Command line overrides specified config file", func() {
if runtime.GOOS == "windows" {
if runtime.GOOS == windows {
cfg := NewCfg()
cfg.Load(&CommandLineArgs{
HomePath: "../../",
@ -150,7 +155,7 @@ func TestLoadingSettings(t *testing.T) {
})
Convey("Can use environment variables in config values", func() {
if runtime.GOOS == "windows" {
if runtime.GOOS == windows {
os.Setenv("GF_DATA_PATH", `c:\tmp\env_override`)
cfg := NewCfg()
cfg.Load(&CommandLineArgs{