From a134b47e019fe8129ee6530e3ba091dcffb8645c Mon Sep 17 00:00:00 2001 From: juanicabanas Date: Thu, 9 Mar 2023 16:58:29 -0300 Subject: [PATCH] PublicDashboards: Show email sharing feature depending on featureEnabled flag (#64555) --- packages/grafana-e2e-selectors/src/selectors/pages.ts | 1 + .../ConfigPublicDashboard/ConfigPublicDashboard.tsx | 5 ++--- .../ConfigPublicDashboard/EmailSharingConfiguration.tsx | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/grafana-e2e-selectors/src/selectors/pages.ts b/packages/grafana-e2e-selectors/src/selectors/pages.ts index 15fece4f375..5f6bace7288 100644 --- a/packages/grafana-e2e-selectors/src/selectors/pages.ts +++ b/packages/grafana-e2e-selectors/src/selectors/pages.ts @@ -201,6 +201,7 @@ export const Pages = { NoUpsertPermissionsWarningAlert: 'data-testid public dashboard no upsert permissions alert', EnableTimeRangeSwitch: 'data-testid public dashboard on off switch for time range', EmailSharingConfiguration: { + Container: 'data-testid email sharing config container', ShareType: 'data-testid public dashboard share type', EmailSharingInput: 'data-testid public dashboard email sharing input', EmailSharingInviteButton: 'data-testid public dashboard email sharing invite button', diff --git a/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ConfigPublicDashboard/ConfigPublicDashboard.tsx b/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ConfigPublicDashboard/ConfigPublicDashboard.tsx index 70183531042..1897cb0cc16 100644 --- a/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ConfigPublicDashboard/ConfigPublicDashboard.tsx +++ b/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ConfigPublicDashboard/ConfigPublicDashboard.tsx @@ -4,9 +4,8 @@ import React, { useContext } from 'react'; import { useForm } from 'react-hook-form'; import { GrafanaTheme2 } from '@grafana/data/src'; -import { GrafanaEdition } from '@grafana/data/src/types/config'; import { selectors as e2eSelectors } from '@grafana/e2e-selectors/src'; -import { config, reportInteraction } from '@grafana/runtime/src'; +import { config, featureEnabled, reportInteraction } from '@grafana/runtime/src'; import { ClipboardButton, Field, @@ -55,7 +54,7 @@ const ConfigPublicDashboard = () => { const hasWritePermissions = contextSrv.hasAccess(AccessControlAction.DashboardsPublicWrite, isOrgAdmin()); const hasEmailSharingEnabled = - config.licenseInfo.edition === GrafanaEdition.Enterprise && !!config.featureToggles.publicDashboardsEmailSharing; + !!config.featureToggles.publicDashboardsEmailSharing && featureEnabled('publicDashboardsEmailSharing'); const dashboardState = useSelector((store) => store.dashboard); const dashboard = dashboardState.getModel()!; const dashboardVariables = dashboard.getVariables(); diff --git a/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ConfigPublicDashboard/EmailSharingConfiguration.tsx b/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ConfigPublicDashboard/EmailSharingConfiguration.tsx index d9026bb3009..370300f6ae2 100644 --- a/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ConfigPublicDashboard/EmailSharingConfiguration.tsx +++ b/public/app/features/dashboard/components/ShareModal/SharePublicDashboard/ConfigPublicDashboard/EmailSharingConfiguration.tsx @@ -144,7 +144,7 @@ export const EmailSharingConfiguration = () => { }; return ( -
+