opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-09-28 15:53:46 +08:00
Code Issues Packages Projects Releases Wiki Activity

GoogleCloudMonitoring: use typed struct in newInstanceSettings (#58440)

Browse Source
This commit is contained in:
Andres Martinez Gotor
2022-11-09 09:38:06 +01:00
committed by GitHub
parent 6ed35292fe
commit 9778d642df
2 changed files with 43 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
pkg/tsdb/cloudmonitoring/cloudmonitoring_test.go
View File

@ -13,11 +13,40 @@ import (
"github.com/grafana/grafana-plugin-sdk-go/backend"
"github.com/grafana/grafana-plugin-sdk-go/backend/datasource"
"github.com/grafana/grafana-plugin-sdk-go/backend/instancemgmt"
"github.com/grafana/grafana/pkg/infra/httpclient"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestNewInstanceSettings(t *testing.T) {
t.Run("should create a new instance with empty settings", func(t *testing.T) {
cli := httpclient.NewProvider()
f := newInstanceSettings(cli)
dsInfo, err := f(backend.DataSourceInstanceSettings{
JSONData: json.RawMessage(`{}`),
})
require.NoError(t, err)
assert.NotNil(t, dsInfo)
assert.Equal(t, jwtAuthentication, dsInfo.(*datasourceInfo).authenticationType)
})
t.Run("should create a new instance parsing settings", func(t *testing.T) {
cli := httpclient.NewProvider()
f := newInstanceSettings(cli)
dsInfo, err := f(backend.DataSourceInstanceSettings{
JSONData: json.RawMessage(`{"authenticationType": "test", "defaultProject": "test", "clientEmail": "test", "tokenUri": "test"}`),
})
require.NoError(t, err)
assert.NotNil(t, dsInfo)
dsInfoCasted := dsInfo.(*datasourceInfo)
assert.Equal(t, "test", dsInfoCasted.authenticationType)
assert.Equal(t, "test", dsInfoCasted.defaultProject)
assert.Equal(t, "test", dsInfoCasted.clientEmail)
assert.Equal(t, "test", dsInfoCasted.tokenUri)
})
}
func TestCloudMonitoring(t *testing.T) {
service := &Service{}