opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-08-02 08:32:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Plugins: Remove dead CLI code and use pkg/plugins for uninstall process (#67711)

Browse Source 
* remove dead code and use pkg/plugins for uninstall process

* fix linter
This commit is contained in:
Will Browne
2023-05-03 14:52:57 +02:00
committed by GitHub
parent 471a03328b
commit 6cd042ed16
8 changed files with 42 additions and 125 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
pkg/cmd/grafana-cli/commands/upgrade_command.go
View File

@ -12,32 +12,32 @@ import (
)
func (cmd Command) upgradeCommand(c utils.CommandLine) error {
ctx := context.Background()
pluginsDir := c.PluginDirectory()
pluginName := c.Args().First()
localPlugin, err := services.ReadPlugin(pluginsDir, pluginName)
pluginID := c.Args().First()
localPlugin, err := services.ReadPlugin(pluginsDir, pluginID)
if err != nil {
return err
}
plugin, err2 := cmd.Client.GetPlugin(pluginName, c.PluginRepoURL())
if err2 != nil {
return err2
plugin, err := cmd.Client.GetPlugin(pluginID, c.PluginRepoURL())
if err != nil {
return err
}
if shouldUpgrade(localPlugin.Info.Version, &plugin) {
if err := services.RemoveInstalledPlugin(pluginsDir, pluginName); err != nil {
return fmt.Errorf("failed to remove plugin '%s': %w", pluginName, err)
if err = uninstallPlugin(ctx, pluginID, c); err != nil {
return fmt.Errorf("failed to remove plugin '%s': %w", pluginID, err)
}
err := installPlugin(context.Background(), pluginName, "", c)
err = installPlugin(ctx, pluginID, "", c)
if err == nil {
logRestartNotice()
}
return err
}
logger.Infof("%s %s is up to date \n", color.GreenString("✔"), pluginName)
logger.Infof("%s %s is up to date \n", color.GreenString("✔"), pluginID)
return nil
}