diff --git a/public/app/core/utils/query.ts b/public/app/core/utils/query.ts index 6fd904ce22a..e09ecb1a71f 100644 --- a/public/app/core/utils/query.ts +++ b/public/app/core/utils/query.ts @@ -16,6 +16,7 @@ export const getNextRefIdChar = (queries: DataQuery[]): string => { export function addQuery(queries: DataQuery[], query?: Partial): DataQuery[] { const q = query || {}; q.refId = getNextRefIdChar(queries); + q.hide = false; return [...queries, q as DataQuery]; } diff --git a/public/app/features/alerting/components/AlertDefinitionOptions.tsx b/public/app/features/alerting/components/AlertDefinitionOptions.tsx index e70ffba47e1..6df1ed8beb6 100644 --- a/public/app/features/alerting/components/AlertDefinitionOptions.tsx +++ b/public/app/features/alerting/components/AlertDefinitionOptions.tsx @@ -1,9 +1,8 @@ -import React, { FC, FormEvent } from 'react'; +import React, { FC, FormEvent, useState } from 'react'; import { css } from 'emotion'; import { GrafanaTheme } from '@grafana/data'; -import { Field, Input, Select, TextArea, useStyles } from '@grafana/ui'; +import { Field, Input, Tab, TabContent, TabsBar, TextArea, useStyles } from '@grafana/ui'; import { AlertDefinition, NotificationChannelType } from 'app/types'; -import { mapChannelsToSelectableValue } from '../utils/notificationChannels'; interface Props { alertDefinition: AlertDefinition; @@ -11,45 +10,70 @@ interface Props { onChange: (event: FormEvent) => void; } -export const AlertDefinitionOptions: FC = ({ alertDefinition, notificationChannelTypes, onChange }) => { +enum Tabs { + Alert = 'alert', + Panel = 'panel', +} + +const tabs = [ + { id: Tabs.Alert, text: 'Alert definition' }, + { id: Tabs.Panel, text: 'Panel' }, +]; + +export const AlertDefinitionOptions: FC = ({ alertDefinition, onChange }) => { const styles = useStyles(getStyles); + const [activeTab, setActiveTab] = useState(Tabs.Alert); return ( -
-
-

Alert definition

- - - - -