opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-07-31 06:12:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Plugins: Support changing plugin IDs (hardcoded) (#67867)

Browse Source
This commit is contained in:
Ryan McKinley
2023-06-02 10:46:12 -07:00
committed by GitHub
parent 4fdccef7b3
commit 422684d8b0
9 changed files with 104 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
pkg/plugins/manager/registry/in_memory_test.go
View File

@ -15,9 +15,7 @@ const pluginID = "test-ds"
func TestInMemory(t *testing.T) {
t.Run("Test mix of registry operations", func(t *testing.T) {
i := &InMemory{
store: map[string]*plugins.Plugin{},
}
i := NewInMemory()
ctx := context.Background()
p, exists := i.Plugin(ctx, pluginID)
@ -272,3 +270,45 @@ func TestInMemory_Remove(t *testing.T) {
})
}
}
func TestAliasSupport(t *testing.T) {
t.Run("Test alias operations", func(t *testing.T) {
i := NewInMemory()
ctx := context.Background()
pluginIdNew := "plugin-new"
pluginIdOld := "plugin-old"
p, exists := i.Plugin(ctx, pluginIdNew)
require.False(t, exists)
require.Nil(t, p)
pluginNew := &plugins.Plugin{
JSONData: plugins.JSONData{
ID: pluginIdNew,
},
Alias: pluginIdOld, // TODO: move to JSONData
}
err := i.Add(ctx, pluginNew)
require.NoError(t, err)
// Can lookup by the new ID
found, exists := i.Plugin(ctx, pluginIdNew)
require.True(t, exists)
require.Equal(t, pluginNew, found)
// Can lookup by the old ID
found, exists = i.Plugin(ctx, pluginIdOld)
require.True(t, exists)
require.Equal(t, pluginNew, found)
// Register the old plugin and look it up
pluginOld := &plugins.Plugin{JSONData: plugins.JSONData{
ID: pluginIdOld,
}}
require.NoError(t, i.Add(ctx, pluginOld))
found, exists = i.Plugin(ctx, pluginIdOld)
require.True(t, exists)
require.Equal(t, pluginOld, found)
})
}