opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-07-29 12:32:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

plugins: Don't exit on duplicate plugin (#28390)

Browse Source 
* plugins: Don't exit on duplicate plugin

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

* Add missing files

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>

* Fix test

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
This commit is contained in:
Arve Knudsen
2020-10-21 12:39:41 +02:00
committed by GitHub
parent 13e67660f5
commit 4084b53f91
8 changed files with 73 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
pkg/plugins/plugins_test.go
View File

@ -2,6 +2,7 @@ package plugins
import (
"context"
"errors"
"fmt"
"path/filepath"
"testing"
@ -163,6 +164,23 @@ func TestPluginManager_Init(t *testing.T) {
require.Empty(t, pm.scanningErrors)
assert.Equal(t, []string{"gel"}, fm.registeredPlugins)
})
t.Run("With nested plugin duplicating parent", func(t *testing.T) {
origPluginsPath := setting.PluginsPath
t.Cleanup(func() {
setting.PluginsPath = origPluginsPath
})
setting.PluginsPath = "testdata/duplicate-plugins"
pm := &PluginManager{
Cfg: &setting.Cfg{},
}
err := pm.Init()
require.NoError(t, err)
assert.Len(t, pm.scanningErrors, 1)
assert.True(t, errors.Is(pm.scanningErrors[0], duplicatePluginError{}))
})
}
func TestPluginManager_IsBackendOnlyPlugin(t *testing.T) {