From 35954d7b6fef8fa75e22a6915a89a641f362023a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Torkel=20=C3=96degaard?= Date: Mon, 5 Aug 2019 09:19:31 +0200 Subject: [PATCH] CI: Added metric to track strict null erros (#18379) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * CI: Added metric to track strict null errros * Update scripts/ci-frontend-metrics.sh Co-Authored-By: Hugo Häggmark --- scripts/ci-frontend-metrics.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/ci-frontend-metrics.sh b/scripts/ci-frontend-metrics.sh index a6d57faf0da..ca369bdf004 100755 --- a/scripts/ci-frontend-metrics.sh +++ b/scripts/ci-frontend-metrics.sh @@ -3,16 +3,16 @@ echo -e "Collecting code stats (typescript errors & more)" -ERROR_COUNT_LIMIT=0 +ERROR_COUNT_LIMIT=1566 DIRECTIVES_LIMIT=172 CONTROLLERS_LIMIT=139 -ERROR_COUNT="$(./node_modules/.bin/tsc --project tsconfig.json --noEmit --noImplicitAny true | grep -oP 'Found \K(\d+)')" +ERROR_COUNT="$(./node_modules/.bin/tsc --project tsconfig.json --noEmit --strict true | grep -oP 'Found \K(\d+)')" DIRECTIVES="$(grep -r -o directive public/app/**/* | wc -l)" CONTROLLERS="$(grep -r -oP 'class .*Ctrl' public/app/**/* | wc -l)" if [ "$ERROR_COUNT" -gt $ERROR_COUNT_LIMIT ]; then - echo -e "Typescript errors $ERROR_COUNT exceeded $ERROR_COUNT_LIMIT so failing build" + echo -e "Typescript strict errors $ERROR_COUNT exceeded $ERROR_COUNT_LIMIT so failing build" exit 1 fi @@ -32,7 +32,7 @@ echo -e "Controllers: $CONTROLLERS" if [ "${CIRCLE_BRANCH}" == "master" ]; then ./scripts/ci-metrics-publisher.sh \ - grafana.ci-code.noImplicitAny="$ERROR_COUNT" \ + grafana.ci-code.strictErrors="$ERROR_COUNT" \ grafana.ci-code.directives="$DIRECTIVES" \ grafana.ci-code.controllers="$CONTROLLERS" fi