From 334cb41a995b4e28af5bed51a0f00a102c4a1ad8 Mon Sep 17 00:00:00 2001 From: Bill Oley Date: Fri, 25 Sep 2020 09:24:16 -0400 Subject: [PATCH] Move error log in social.go inside err != nil (#27804) --- pkg/login/social/social.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/login/social/social.go b/pkg/login/social/social.go index b5524fc8f60..74ee6056a6f 100644 --- a/pkg/login/social/social.go +++ b/pkg/login/social/social.go @@ -258,8 +258,8 @@ func GetOAuthHttpClient(name string) (*http.Client, error) { if info.TlsClientCert != "" || info.TlsClientKey != "" { cert, err := tls.LoadX509KeyPair(info.TlsClientCert, info.TlsClientKey) - logger.Error("Failed to setup TlsClientCert", "oauth", name, "error", err) if err != nil { + logger.Error("Failed to setup TlsClientCert", "oauth", name, "error", err) return nil, fmt.Errorf("Failed to setup TlsClientCert") }