Plugins: Plugin Store API returns DTO model (#41340)

* toying around

* fix refs

* remove unused fields

* go further

* add context

* ensure streaming handler is set

pkg/plugins/plugins.go

@@ -45,6 +45,65 @@ type Plugin struct {
 	log      log.Logger
 }
 
+type PluginDTO struct {
+	JSONData
+
+	PluginDir string
+	Class     Class
+
+	// App fields
+	IncludedInAppID string
+	DefaultNavURL   string
+	Pinned          bool
+
+	// Signature fields
+	Signature      SignatureStatus
+	SignatureType  SignatureType
+	SignatureOrg   string
+	SignedFiles    PluginFiles
+	SignatureError *SignatureError
+
+	// GCOM update checker fields
+	GrafanaComVersion   string
+	GrafanaComHasUpdate bool
+
+	// SystemJS fields
+	Module  string
+	BaseURL string
+
+	// temporary
+	backend.StreamHandler
+}
+
+func (p PluginDTO) SupportsStreaming() bool {
+	return p.StreamHandler != nil
+}
+
+func (p PluginDTO) IsApp() bool {
+	return p.Type == "app"
+}
+
+func (p PluginDTO) IsCorePlugin() bool {
+	return p.Class == Core
+}
+
+func (p PluginDTO) IncludedInSignature(file string) bool {
+	// permit Core plugin files
+	if p.IsCorePlugin() {
+		return true
+	}
+
+	// permit when no signed files (no MANIFEST)
+	if p.SignedFiles == nil {
+		return true
+	}
+
+	if _, exists := p.SignedFiles[file]; !exists {
+		return false
+	}
+	return true
+}
+
 // JSONData represents the plugin's plugin.json
 type JSONData struct {
 	// Common settings
@@ -252,6 +311,29 @@ type PluginClient interface {
 	backend.StreamHandler
 }
 
+func (p *Plugin) ToDTO() PluginDTO {
+	c, _ := p.Client()
+
+	return PluginDTO{
+		JSONData:            p.JSONData,
+		PluginDir:           p.PluginDir,
+		Class:               p.Class,
+		IncludedInAppID:     p.IncludedInAppID,
+		DefaultNavURL:       p.DefaultNavURL,
+		Pinned:              p.Pinned,
+		Signature:           p.Signature,
+		SignatureType:       p.SignatureType,
+		SignatureOrg:        p.SignatureOrg,
+		SignedFiles:         p.SignedFiles,
+		SignatureError:      p.SignatureError,
+		GrafanaComVersion:   p.GrafanaComVersion,
+		GrafanaComHasUpdate: p.GrafanaComHasUpdate,
+		Module:              p.Module,
+		BaseURL:             p.BaseURL,
+		StreamHandler:       c,
+	}
+}
+
 func (p *Plugin) StaticRoute() *StaticRoute {
 	if p.IsCorePlugin() {
 		return nil
@@ -288,33 +370,6 @@ func (p *Plugin) IsExternalPlugin() bool {
 	return p.Class == External
 }
 
-func (p *Plugin) SupportsStreaming() bool {
-	pluginClient, ok := p.Client()
-	if !ok {
-		return false
-	}
-
-	_, ok = pluginClient.(backend.StreamHandler)
-	return ok
-}
-
-func (p *Plugin) IncludedInSignature(file string) bool {
-	// permit Core plugin files
-	if p.IsCorePlugin() {
-		return true
-	}
-
-	// permit when no signed files (no MANIFEST)
-	if p.SignedFiles == nil {
-		return true
-	}
-
-	if _, exists := p.SignedFiles[file]; !exists {
-		return false
-	}
-	return true
-}
-
 type Class string
 
 const (