opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-07-29 16:32:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Rendering: add capabilities check (#44470)

Browse Source 
* #44449: add feature check to rendering service

* #44449: formatting

* #44449: rename feature -> capability (https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack/getCapabilities, https://developer.mozilla.org/en-US/docs/Web/API/InputDeviceInfo/getCapabilities)

* #44449: refactor

* #44449: remove commented code

* Update pkg/services/rendering/capabilities.go

Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com>

* #44449: review fixes

Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com>
This commit is contained in:
Artur Wierzbicki
2022-01-28 21:24:15 +04:00
committed by GitHub
parent 4e37a53a1c
commit 254c59725e
5 changed files with 212 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

136
pkg/services/rendering/capabilities_test.go Normal file
View File

@ -0,0 +1,136 @@
package rendering
import (
"testing"
"github.com/stretchr/testify/require"
"github.com/grafana/grafana/pkg/infra/log"
"github.com/grafana/grafana/pkg/plugins"
"github.com/grafana/grafana/pkg/setting"
)
type dummyPluginManager struct{}
func (d *dummyPluginManager) Renderer() *plugins.Plugin {
return nil
}
var dummyRendererUrl = "http://dummyurl.com"
var testCapabilitySemverConstraint = "> 1.0.0"
var testCapabilityName = CapabilityName("TestCap")
var testCapabilityNameInvalidSemver = CapabilityName("TestCapInvalidSemver")
func TestCapabilities(t *testing.T) {
cfg := setting.NewCfg()
rs := &RenderingService{
Cfg: cfg,
RendererPluginManager: &dummyPluginManager{},
log: log.New("test-capabilities-rendering-service"),
capabilities: []Capability{
{name: testCapabilityName, semverConstraint: testCapabilitySemverConstraint},
{name: testCapabilityNameInvalidSemver, semverConstraint: "asfasf"},
},
}
tests := []struct {
name string
rendererUrl string
rendererVersion string
capabilityName CapabilityName
expectedError error
expectedResult CapabilitySupportRequestResult
}{
{
name: "when image-renderer plugin is not available",
rendererUrl: "",
rendererVersion: "",
capabilityName: testCapabilityName,
expectedError: ErrRenderUnavailable,
expectedResult: CapabilitySupportRequestResult{
IsSupported: false,
SemverConstraint: "",
},
},
{
name: "when image-renderer plugin version is not populated",
rendererUrl: dummyRendererUrl,
rendererVersion: "",
capabilityName: testCapabilityName,
expectedError: ErrInvalidPluginVersion,
expectedResult: CapabilitySupportRequestResult{
IsSupported: false,
SemverConstraint: testCapabilitySemverConstraint,
},
},
{
name: "when image-renderer plugin version is not valid",
rendererUrl: dummyRendererUrl,
rendererVersion: "abcd",
capabilityName: testCapabilityName,
expectedError: ErrInvalidPluginVersion,
expectedResult: CapabilitySupportRequestResult{
IsSupported: false,
SemverConstraint: testCapabilitySemverConstraint,
},
},
{
name: "when image-renderer version does not match target constraint",
rendererUrl: dummyRendererUrl,
rendererVersion: "1.0.0",
capabilityName: testCapabilityName,
expectedError: nil,
expectedResult: CapabilitySupportRequestResult{
IsSupported: false,
SemverConstraint: testCapabilitySemverConstraint,
},
},
{
name: "when image-renderer version matches target constraint",
rendererUrl: dummyRendererUrl,
rendererVersion: "2.0.0",
capabilityName: testCapabilityName,
expectedError: nil,
expectedResult: CapabilitySupportRequestResult{
IsSupported: true,
SemverConstraint: testCapabilitySemverConstraint,
},
},
{
name: "when capability is unknown",
rendererUrl: dummyRendererUrl,
rendererVersion: "1.0.0",
capabilityName: CapabilityName("unknown"),
expectedError: ErrUnknownCapability,
expectedResult: CapabilitySupportRequestResult{
IsSupported: false,
SemverConstraint: "",
},
},
{
name: "when capability has invalid semver constraint",
rendererUrl: dummyRendererUrl,
rendererVersion: "1.0.0",
capabilityName: testCapabilityNameInvalidSemver,
expectedError: ErrUnknownCapability,
expectedResult: CapabilitySupportRequestResult{
IsSupported: false,
SemverConstraint: "asfasf",
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
rs.Cfg.RendererUrl = tt.rendererUrl
rs.version = tt.rendererVersion
res, err := rs.HasCapability(tt.capabilityName)
if tt.expectedError == nil {
require.NoError(t, err)
} else {
require.ErrorIs(t, err, tt.expectedError)
}
require.Equal(t, tt.expectedResult, res)
})
}
}