opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-07-30 07:42:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

Plugins: Move backend plugin manager to service (#21474)

Browse Source 
Moves backend plugin manager to service instead of
global functions in backendplugin package.

Closes #20053
This commit is contained in:
Marcus Efraimsson
2020-01-13 20:18:45 +01:00
committed by GitHub
parent bb849d53bf
commit 1a810ebfe4
9 changed files with 188 additions and 167 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/plugins/renderer_plugin.go
View File

@ -14,11 +14,12 @@ import (
type RendererPlugin struct {
PluginBase
Executable string `json:"executable,omitempty"`
GrpcPlugin pluginModel.RendererPlugin
Executable string `json:"executable,omitempty"`
GrpcPlugin pluginModel.RendererPlugin
backendPluginManager backendplugin.Manager
}
func (r *RendererPlugin) Load(decoder *json.Decoder, pluginDir string) error {
func (r *RendererPlugin) Load(decoder *json.Decoder, pluginDir string, backendPluginManager backendplugin.Manager) error {
if err := decoder.Decode(r); err != nil {
return err
}
@ -27,12 +28,14 @@ func (r *RendererPlugin) Load(decoder *json.Decoder, pluginDir string) error {
return err
}
r.backendPluginManager = backendPluginManager
cmd := ComposePluginStartCommmand("plugin_start")
fullpath := path.Join(r.PluginDir, cmd)
descriptor := backendplugin.NewRendererPluginDescriptor(r.Id, fullpath, backendplugin.PluginStartFuncs{
OnLegacyStart: r.onLegacyPluginStart,
})
if err := backendplugin.Register(descriptor); err != nil {
if err := backendPluginManager.Register(descriptor); err != nil {
return errutil.Wrapf(err, "Failed to register backend plugin")
}
@ -41,7 +44,7 @@ func (r *RendererPlugin) Load(decoder *json.Decoder, pluginDir string) error {
}
func (r *RendererPlugin) Start(ctx context.Context) error {
if err := backendplugin.StartPlugin(ctx, r.Id); err != nil {
if err := r.backendPluginManager.StartPlugin(ctx, r.Id); err != nil {
return errutil.Wrapf(err, "Failed to start renderer plugin")
}