diff --git a/public/app/plugins/datasource/mssql/datasource.ts b/public/app/plugins/datasource/mssql/datasource.ts index 6a3c81b4a27..d533515091a 100644 --- a/public/app/plugins/datasource/mssql/datasource.ts +++ b/public/app/plugins/datasource/mssql/datasource.ts @@ -2,12 +2,11 @@ import { map as _map } from 'lodash'; import { lastValueFrom, of } from 'rxjs'; import { catchError, map, mapTo } from 'rxjs/operators'; import { BackendDataSourceResponse, DataSourceWithBackend, FetchResponse, getBackendSrv } from '@grafana/runtime'; -import { AnnotationEvent, DataSourceInstanceSettings, MetricFindValue, ScopedVars } from '@grafana/data'; +import { AnnotationEvent, DataSourceInstanceSettings, MetricFindValue, ScopedVars, TimeRange } from '@grafana/data'; import ResponseParser from './response_parser'; import { getTemplateSrv, TemplateSrv } from 'app/features/templating/template_srv'; import { MssqlOptions, MssqlQuery, MssqlQueryForInterpolation } from './types'; -import { getTimeSrv, TimeSrv } from 'app/features/dashboard/services/TimeSrv'; import { toTestingStatus } from '@grafana/runtime/src/utils/queryResponse'; export class MssqlDatasource extends DataSourceWithBackend { @@ -18,8 +17,7 @@ export class MssqlDatasource extends DataSourceWithBackend, - private readonly templateSrv: TemplateSrv = getTemplateSrv(), - private readonly timeSrv: TimeSrv = getTimeSrv() + private readonly templateSrv: TemplateSrv = getTemplateSrv() ) { super(instanceSettings); this.name = instanceSettings.name; @@ -123,7 +121,7 @@ export class MssqlDatasource extends DataSourceWithBackend ({ ...(jest.requireActual('@grafana/runtime') as unknown as object), @@ -17,15 +16,13 @@ describe('MSSQLDatasource', () => { const templateSrv: TemplateSrv = new TemplateSrv(); const fetchMock = jest.spyOn(backendSrv, 'fetch'); - const ctx: any = { - timeSrv: new TimeSrvStub(), - }; + const ctx: any = {}; beforeEach(() => { jest.clearAllMocks(); ctx.instanceSettings = { name: 'mssql' }; - ctx.ds = new MssqlDatasource(ctx.instanceSettings, templateSrv, ctx.timeSrv); + ctx.ds = new MssqlDatasource(ctx.instanceSettings, templateSrv); }); describe('When performing annotationQuery', () => { @@ -255,7 +252,6 @@ describe('MSSQLDatasource', () => { }; beforeEach(() => { - ctx.timeSrv.setTime(time); fetchMock.mockImplementation(() => of(createFetchResponse(response))); return ctx.ds.metricFindQuery(query, { range: time }); diff --git a/public/app/plugins/datasource/mysql/datasource.ts b/public/app/plugins/datasource/mysql/datasource.ts index 7865155d6e1..a2e77ec4941 100644 --- a/public/app/plugins/datasource/mysql/datasource.ts +++ b/public/app/plugins/datasource/mysql/datasource.ts @@ -9,7 +9,6 @@ import ResponseParser from './response_parser'; import { MySQLOptions, MySQLQuery, MysqlQueryForInterpolation } from './types'; import { getTemplateSrv, TemplateSrv } from 'app/features/templating/template_srv'; import { getSearchFilterScopedVar } from '../../../features/variables/utils'; -import { getTimeSrv, TimeSrv } from 'app/features/dashboard/services/TimeSrv'; import { toTestingStatus } from '@grafana/runtime/src/utils/queryResponse'; export class MysqlDatasource extends DataSourceWithBackend { @@ -21,8 +20,7 @@ export class MysqlDatasource extends DataSourceWithBackend, - private readonly templateSrv: TemplateSrv = getTemplateSrv(), - private readonly timeSrv: TimeSrv = getTimeSrv() + private readonly templateSrv: TemplateSrv = getTemplateSrv() ) { super(instanceSettings); this.name = instanceSettings.name; @@ -140,7 +138,7 @@ export class MysqlDatasource extends DataSourceWithBackend { } as unknown as DataSourceInstanceSettings; const templateSrv: TemplateSrv = new TemplateSrv(); const variable = { ...initialCustomVariableModelState }; - const raw = { - from: toUtc('2018-04-25 10:00'), - to: toUtc('2018-04-25 11:00'), - }; - const timeSrvMock: any = { - timeRange: () => ({ - from: raw.from, - to: raw.to, - raw: raw, - }), - }; fetchMock.mockImplementation((options) => of(createFetchResponse(response))); - const ds = new MysqlDatasource(instanceSettings, templateSrv, timeSrvMock); + const ds = new MysqlDatasource(instanceSettings, templateSrv); return { ds, variable, templateSrv, fetchMock }; }; diff --git a/public/app/plugins/datasource/postgres/datasource.ts b/public/app/plugins/datasource/postgres/datasource.ts index 2b4b448e03e..6d6605740d3 100644 --- a/public/app/plugins/datasource/postgres/datasource.ts +++ b/public/app/plugins/datasource/postgres/datasource.ts @@ -2,12 +2,11 @@ import { map as _map } from 'lodash'; import { lastValueFrom, of } from 'rxjs'; import { map, catchError } from 'rxjs/operators'; import { BackendDataSourceResponse, DataSourceWithBackend, FetchResponse, getBackendSrv } from '@grafana/runtime'; -import { AnnotationEvent, DataSourceInstanceSettings, MetricFindValue, ScopedVars } from '@grafana/data'; +import { AnnotationEvent, DataSourceInstanceSettings, MetricFindValue, ScopedVars, TimeRange } from '@grafana/data'; import ResponseParser from './response_parser'; import PostgresQueryModel from 'app/plugins/datasource/postgres/postgres_query_model'; import { getTemplateSrv, TemplateSrv } from 'app/features/templating/template_srv'; -import { getTimeSrv, TimeSrv } from 'app/features/dashboard/services/TimeSrv'; //Types import { PostgresOptions, PostgresQuery, PostgresQueryForInterpolation } from './types'; import { getSearchFilterScopedVar } from '../../../features/variables/utils'; @@ -23,8 +22,7 @@ export class PostgresDatasource extends DataSourceWithBackend, - private readonly templateSrv: TemplateSrv = getTemplateSrv(), - private readonly timeSrv: TimeSrv = getTimeSrv() + private readonly templateSrv: TemplateSrv = getTemplateSrv() ) { super(instanceSettings); this.name = instanceSettings.name; @@ -142,7 +140,7 @@ export class PostgresDatasource extends DataSourceWithBackend ({ @@ -43,21 +41,10 @@ describe('PostgreSQLDatasource', () => { }, } as unknown as DataSourceInstanceSettings; const templateSrv: TemplateSrv = new TemplateSrv(); - const raw = { - from: toUtc('2018-04-25 10:00'), - to: toUtc('2018-04-25 11:00'), - }; - const timeSrvMock = { - timeRange: () => ({ - from: raw.from, - to: raw.to, - raw: raw, - }), - } as unknown as TimeSrv; const variable = { ...initialCustomVariableModelState }; - const ds = new PostgresDatasource(instanceSettings, templateSrv, timeSrvMock); + const ds = new PostgresDatasource(instanceSettings, templateSrv); - return { ds, templateSrv, timeSrvMock, variable }; + return { ds, templateSrv, variable }; }; // https://rxjs-dev.firebaseapp.com/guide/testing/marble-testing