opensource/grafana
1
0
Fork 0
mirror of https://github.com/grafana/grafana.git synced 2025-07-31 21:42:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Chore: Implement revive (#16200)

Browse Source 
Since we do not like some of the default golint rules,
this commit proposes to use https://github.com/mgechev/revive.

And potential revive speed-up should't hurt :).

Right now, presented config (./conf/revive.toml) is permissive,
we might improve it over time however. Fixes for found revive
issues in the code are very limited so it wouldn't be large to review.

Also in this commit:

* Add annotations for makefile commands and declare phony targets

* Rename "gometalinter" script and CI command to "lint"
  since we are doing there a bit more then using gometalinter package

* Add Makefile rules to .editorconfig

* Documentation which mentioned "golint" replaced with revive

Fixes #16109
Ref #16160
This commit is contained in:
Oleg Gaidarenko
2019-03-27 17:53:49 +01:00
committed by GitHub
parent 33d1d427bc
commit 04b3afcd15
10 changed files with 110 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/cmd/grafana-cli/commands/commands.go
View File

@ -34,9 +34,9 @@ func runDbCommand(command func(commandLine CommandLine) error) func(context *cli
cmd.ShowHelp()
os.Exit(1)
} else {
logger.Info("\n\n")
}
logger.Info("\n\n")
}
}
@ -50,9 +50,9 @@ func runPluginCommand(command func(commandLine CommandLine) error) func(context
cmd.ShowHelp()
os.Exit(1)
} else {
logger.Info("\nRestart grafana after installing plugins . <service grafana-server restart>\n\n")
}
logger.Info("\nRestart grafana after installing plugins . <service grafana-server restart>\n\n")
}
}