mirror of
				https://gitcode.com/gitea/gitea.git
				synced 2025-10-25 12:26:40 +08:00 
			
		
		
		
	 18de83b2a3
			
		
	
	18de83b2a3
	
	
	
		
			
			## Changes
- Adds the following high level access scopes, each with `read` and
`write` levels:
    - `activitypub`
    - `admin` (hidden if user is not a site admin)
    - `misc`
    - `notification`
    - `organization`
    - `package`
    - `issue`
    - `repository`
    - `user`
- Adds new middleware function `tokenRequiresScopes()` in addition to
`reqToken()`
  -  `tokenRequiresScopes()` is used for each high-level api section
- _if_ a scoped token is present, checks that the required scope is
included based on the section and HTTP method
  - `reqToken()` is used for individual routes
- checks that required authentication is present (but does not check
scope levels as this will already have been handled by
`tokenRequiresScopes()`
- Adds migration to convert old scoped access tokens to the new set of
scopes
- Updates the user interface for scope selection
### User interface example
<img width="903" alt="Screen Shot 2023-05-31 at 1 56 55 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/654766ec-2143-4f59-9037-3b51600e32f3">
<img width="917" alt="Screen Shot 2023-05-31 at 1 56 43 PM"
src="https://github.com/go-gitea/gitea/assets/23248839/1ad64081-012c-4a73-b393-66b30352654c">
## tokenRequiresScopes  Design Decision
- `tokenRequiresScopes()` was added to more reliably cover api routes.
For an incoming request, this function uses the given scope category
(say `AccessTokenScopeCategoryOrganization`) and the HTTP method (say
`DELETE`) and verifies that any scoped tokens in use include
`delete:organization`.
- `reqToken()` is used to enforce auth for individual routes that
require it. If a scoped token is not present for a request,
`tokenRequiresScopes()` will not return an error
## TODO
- [x] Alphabetize scope categories
- [x] Change 'public repos only' to a radio button (private vs public).
Also expand this to organizations
- [X] Disable token creation if no scopes selected. Alternatively, show
warning
- [x] `reqToken()` is missing from many `POST/DELETE` routes in the api.
`tokenRequiresScopes()` only checks that a given token has the correct
scope, `reqToken()` must be used to check that a token (or some other
auth) is present.
   -  _This should be addressed in this PR_
- [x] The migration should be reviewed very carefully in order to
minimize access changes to existing user tokens.
   - _This should be addressed in this PR_
- [x] Link to api to swagger documentation, clarify what
read/write/delete levels correspond to
- [x] Review cases where more than one scope is needed as this directly
deviates from the api definition.
   - _This should be addressed in this PR_
   - For example: 
   ```go
	m.Group("/users/{username}/orgs", func() {
		m.Get("", reqToken(), org.ListUserOrgs)
		m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions)
}, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser,
auth_model.AccessTokenScopeCategoryOrganization),
context_service.UserAssignmentAPI())
   ```
## Future improvements
- [ ] Add required scopes to swagger documentation
- [ ] Redesign `reqToken()` to be opt-out rather than opt-in
- [ ] Subdivide scopes like `repository`
- [ ] Once a token is created, if it has no scopes, we should display
text instead of an empty bullet point
- [ ] If the 'public repos only' option is selected, should read
categories be selected by default
Closes #24501
Closes #24799
Co-authored-by: Jonathan Tran <jon@allspice.io>
Co-authored-by: Kyle D <kdumontnu@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
		
	
		
			
				
	
	
		
			330 lines
		
	
	
		
			11 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			330 lines
		
	
	
		
			11 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2017 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package integration
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"net/http"
 | |
| 	"net/url"
 | |
| 	"testing"
 | |
| 	"time"
 | |
| 
 | |
| 	auth_model "code.gitea.io/gitea/models/auth"
 | |
| 	"code.gitea.io/gitea/models/db"
 | |
| 	issues_model "code.gitea.io/gitea/models/issues"
 | |
| 	repo_model "code.gitea.io/gitea/models/repo"
 | |
| 	"code.gitea.io/gitea/models/unittest"
 | |
| 	user_model "code.gitea.io/gitea/models/user"
 | |
| 	"code.gitea.io/gitea/modules/setting"
 | |
| 	api "code.gitea.io/gitea/modules/structs"
 | |
| 	"code.gitea.io/gitea/tests"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| func TestAPIListIssues(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 
 | |
| 	repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
 | |
| 	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
 | |
| 
 | |
| 	session := loginUser(t, owner.Name)
 | |
| 	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadIssue)
 | |
| 	link, _ := url.Parse(fmt.Sprintf("/api/v1/repos/%s/%s/issues", owner.Name, repo.Name))
 | |
| 
 | |
| 	link.RawQuery = url.Values{"token": {token}, "state": {"all"}}.Encode()
 | |
| 	resp := MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)
 | |
| 	var apiIssues []*api.Issue
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, unittest.GetCount(t, &issues_model.Issue{RepoID: repo.ID}))
 | |
| 	for _, apiIssue := range apiIssues {
 | |
| 		unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: apiIssue.ID, RepoID: repo.ID})
 | |
| 	}
 | |
| 
 | |
| 	// test milestone filter
 | |
| 	link.RawQuery = url.Values{"token": {token}, "state": {"all"}, "type": {"all"}, "milestones": {"ignore,milestone1,3,4"}}.Encode()
 | |
| 	resp = MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	if assert.Len(t, apiIssues, 2) {
 | |
| 		assert.EqualValues(t, 3, apiIssues[0].Milestone.ID)
 | |
| 		assert.EqualValues(t, 1, apiIssues[1].Milestone.ID)
 | |
| 	}
 | |
| 
 | |
| 	link.RawQuery = url.Values{"token": {token}, "state": {"all"}, "created_by": {"user2"}}.Encode()
 | |
| 	resp = MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	if assert.Len(t, apiIssues, 1) {
 | |
| 		assert.EqualValues(t, 5, apiIssues[0].ID)
 | |
| 	}
 | |
| 
 | |
| 	link.RawQuery = url.Values{"token": {token}, "state": {"all"}, "assigned_by": {"user1"}}.Encode()
 | |
| 	resp = MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	if assert.Len(t, apiIssues, 1) {
 | |
| 		assert.EqualValues(t, 1, apiIssues[0].ID)
 | |
| 	}
 | |
| 
 | |
| 	link.RawQuery = url.Values{"token": {token}, "state": {"all"}, "mentioned_by": {"user4"}}.Encode()
 | |
| 	resp = MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	if assert.Len(t, apiIssues, 1) {
 | |
| 		assert.EqualValues(t, 1, apiIssues[0].ID)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestAPICreateIssue(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 	const body, title = "apiTestBody", "apiTestTitle"
 | |
| 
 | |
| 	repoBefore := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
 | |
| 	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repoBefore.OwnerID})
 | |
| 
 | |
| 	session := loginUser(t, owner.Name)
 | |
| 	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteIssue)
 | |
| 	urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues?state=all&token=%s", owner.Name, repoBefore.Name, token)
 | |
| 	req := NewRequestWithJSON(t, "POST", urlStr, &api.CreateIssueOption{
 | |
| 		Body:     body,
 | |
| 		Title:    title,
 | |
| 		Assignee: owner.Name,
 | |
| 	})
 | |
| 	resp := MakeRequest(t, req, http.StatusCreated)
 | |
| 	var apiIssue api.Issue
 | |
| 	DecodeJSON(t, resp, &apiIssue)
 | |
| 	assert.Equal(t, body, apiIssue.Body)
 | |
| 	assert.Equal(t, title, apiIssue.Title)
 | |
| 
 | |
| 	unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{
 | |
| 		RepoID:     repoBefore.ID,
 | |
| 		AssigneeID: owner.ID,
 | |
| 		Content:    body,
 | |
| 		Title:      title,
 | |
| 	})
 | |
| 
 | |
| 	repoAfter := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
 | |
| 	assert.Equal(t, repoBefore.NumIssues+1, repoAfter.NumIssues)
 | |
| 	assert.Equal(t, repoBefore.NumClosedIssues, repoAfter.NumClosedIssues)
 | |
| }
 | |
| 
 | |
| func TestAPIEditIssue(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 
 | |
| 	issueBefore := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 10})
 | |
| 	repoBefore := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issueBefore.RepoID})
 | |
| 	owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repoBefore.OwnerID})
 | |
| 	assert.NoError(t, issueBefore.LoadAttributes(db.DefaultContext))
 | |
| 	assert.Equal(t, int64(1019307200), int64(issueBefore.DeadlineUnix))
 | |
| 	assert.Equal(t, api.StateOpen, issueBefore.State())
 | |
| 
 | |
| 	session := loginUser(t, owner.Name)
 | |
| 	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteIssue)
 | |
| 
 | |
| 	// update values of issue
 | |
| 	issueState := "closed"
 | |
| 	removeDeadline := true
 | |
| 	milestone := int64(4)
 | |
| 	body := "new content!"
 | |
| 	title := "new title from api set"
 | |
| 
 | |
| 	urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d?token=%s", owner.Name, repoBefore.Name, issueBefore.Index, token)
 | |
| 	req := NewRequestWithJSON(t, "PATCH", urlStr, api.EditIssueOption{
 | |
| 		State:          &issueState,
 | |
| 		RemoveDeadline: &removeDeadline,
 | |
| 		Milestone:      &milestone,
 | |
| 		Body:           &body,
 | |
| 		Title:          title,
 | |
| 
 | |
| 		// ToDo change more
 | |
| 	})
 | |
| 	resp := MakeRequest(t, req, http.StatusCreated)
 | |
| 	var apiIssue api.Issue
 | |
| 	DecodeJSON(t, resp, &apiIssue)
 | |
| 
 | |
| 	issueAfter := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 10})
 | |
| 	repoAfter := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issueBefore.RepoID})
 | |
| 
 | |
| 	// check deleted user
 | |
| 	assert.Equal(t, int64(500), issueAfter.PosterID)
 | |
| 	assert.NoError(t, issueAfter.LoadAttributes(db.DefaultContext))
 | |
| 	assert.Equal(t, int64(-1), issueAfter.PosterID)
 | |
| 	assert.Equal(t, int64(-1), issueBefore.PosterID)
 | |
| 	assert.Equal(t, int64(-1), apiIssue.Poster.ID)
 | |
| 
 | |
| 	// check repo change
 | |
| 	assert.Equal(t, repoBefore.NumClosedIssues+1, repoAfter.NumClosedIssues)
 | |
| 
 | |
| 	// API response
 | |
| 	assert.Equal(t, api.StateClosed, apiIssue.State)
 | |
| 	assert.Equal(t, milestone, apiIssue.Milestone.ID)
 | |
| 	assert.Equal(t, body, apiIssue.Body)
 | |
| 	assert.True(t, apiIssue.Deadline == nil)
 | |
| 	assert.Equal(t, title, apiIssue.Title)
 | |
| 
 | |
| 	// in database
 | |
| 	assert.Equal(t, api.StateClosed, issueAfter.State())
 | |
| 	assert.Equal(t, milestone, issueAfter.MilestoneID)
 | |
| 	assert.Equal(t, int64(0), int64(issueAfter.DeadlineUnix))
 | |
| 	assert.Equal(t, body, issueAfter.Content)
 | |
| 	assert.Equal(t, title, issueAfter.Title)
 | |
| }
 | |
| 
 | |
| func TestAPISearchIssues(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 
 | |
| 	token := getUserToken(t, "user2", auth_model.AccessTokenScopeReadIssue)
 | |
| 
 | |
| 	// as this API was used in the frontend, it uses UI page size
 | |
| 	expectedIssueCount := 16 // from the fixtures
 | |
| 	if expectedIssueCount > setting.UI.IssuePagingNum {
 | |
| 		expectedIssueCount = setting.UI.IssuePagingNum
 | |
| 	}
 | |
| 
 | |
| 	link, _ := url.Parse("/api/v1/repos/issues/search")
 | |
| 	query := url.Values{"token": {getUserToken(t, "user1", auth_model.AccessTokenScopeReadIssue)}}
 | |
| 	var apiIssues []*api.Issue
 | |
| 
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req := NewRequest(t, "GET", link.String())
 | |
| 	resp := MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, expectedIssueCount)
 | |
| 
 | |
| 	since := "2000-01-01T00%3A50%3A01%2B00%3A00" // 946687801
 | |
| 	before := time.Unix(999307200, 0).Format(time.RFC3339)
 | |
| 	query.Add("since", since)
 | |
| 	query.Add("before", before)
 | |
| 	query.Add("token", token)
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, 9)
 | |
| 	query.Del("since")
 | |
| 	query.Del("before")
 | |
| 
 | |
| 	query.Add("state", "closed")
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, 2)
 | |
| 
 | |
| 	query.Set("state", "all")
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.EqualValues(t, "18", resp.Header().Get("X-Total-Count"))
 | |
| 	assert.Len(t, apiIssues, 18)
 | |
| 
 | |
| 	query.Add("limit", "10")
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.EqualValues(t, "18", resp.Header().Get("X-Total-Count"))
 | |
| 	assert.Len(t, apiIssues, 10)
 | |
| 
 | |
| 	query = url.Values{"assigned": {"true"}, "state": {"all"}, "token": {token}}
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, 2)
 | |
| 
 | |
| 	query = url.Values{"milestones": {"milestone1"}, "state": {"all"}, "token": {token}}
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, 1)
 | |
| 
 | |
| 	query = url.Values{"milestones": {"milestone1,milestone3"}, "state": {"all"}, "token": {token}}
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, 2)
 | |
| 
 | |
| 	query = url.Values{"owner": {"user2"}, "token": {token}} // user
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, 7)
 | |
| 
 | |
| 	query = url.Values{"owner": {"user3"}, "token": {token}} // organization
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, 5)
 | |
| 
 | |
| 	query = url.Values{"owner": {"user3"}, "team": {"team1"}, "token": {token}} // organization + team
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, 2)
 | |
| }
 | |
| 
 | |
| func TestAPISearchIssuesWithLabels(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 
 | |
| 	// as this API was used in the frontend, it uses UI page size
 | |
| 	expectedIssueCount := 16 // from the fixtures
 | |
| 	if expectedIssueCount > setting.UI.IssuePagingNum {
 | |
| 		expectedIssueCount = setting.UI.IssuePagingNum
 | |
| 	}
 | |
| 
 | |
| 	link, _ := url.Parse("/api/v1/repos/issues/search")
 | |
| 	query := url.Values{"token": {getUserToken(t, "user1", auth_model.AccessTokenScopeReadIssue)}}
 | |
| 	var apiIssues []*api.Issue
 | |
| 
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req := NewRequest(t, "GET", link.String())
 | |
| 	resp := MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, expectedIssueCount)
 | |
| 
 | |
| 	query.Add("labels", "label1")
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, 2)
 | |
| 
 | |
| 	// multiple labels
 | |
| 	query.Set("labels", "label1,label2")
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, 2)
 | |
| 
 | |
| 	// an org label
 | |
| 	query.Set("labels", "orglabel4")
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, 1)
 | |
| 
 | |
| 	// org and repo label
 | |
| 	query.Set("labels", "label2,orglabel4")
 | |
| 	query.Add("state", "all")
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, 2)
 | |
| 
 | |
| 	// org and repo label which share the same issue
 | |
| 	query.Set("labels", "label1,orglabel4")
 | |
| 	link.RawQuery = query.Encode()
 | |
| 	req = NewRequest(t, "GET", link.String())
 | |
| 	resp = MakeRequest(t, req, http.StatusOK)
 | |
| 	DecodeJSON(t, resp, &apiIssues)
 | |
| 	assert.Len(t, apiIssues, 2)
 | |
| }
 |