mirror of
				https://gitcode.com/gitea/gitea.git
				synced 2025-11-01 01:36:12 +08:00 
			
		
		
		
	 8b0aaa5f86
			
		
	
	8b0aaa5f86
	
	
	
		
			
			A testing cleanup. This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot. Reference: https://pkg.go.dev/testing#T.TempDir ```go func TestFoo(t *testing.T) { // before tmpDir, err := os.MkdirTemp("", "") require.NoError(t, err) defer os.RemoveAll(tmpDir) // now tmpDir := t.TempDir() } ``` Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
		
			
				
	
	
		
			55 lines
		
	
	
		
			1.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			55 lines
		
	
	
		
			1.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2019 The Gitea Authors. All rights reserved.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package db_test
 | |
| 
 | |
| import (
 | |
| 	"path/filepath"
 | |
| 	"testing"
 | |
| 
 | |
| 	"code.gitea.io/gitea/models/db"
 | |
| 	issues_model "code.gitea.io/gitea/models/issues"
 | |
| 	"code.gitea.io/gitea/models/unittest"
 | |
| 	"code.gitea.io/gitea/modules/setting"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| func TestDumpDatabase(t *testing.T) {
 | |
| 	assert.NoError(t, unittest.PrepareTestDatabase())
 | |
| 
 | |
| 	dir := t.TempDir()
 | |
| 
 | |
| 	type Version struct {
 | |
| 		ID      int64 `xorm:"pk autoincr"`
 | |
| 		Version int64
 | |
| 	}
 | |
| 	assert.NoError(t, db.GetEngine(db.DefaultContext).Sync2(new(Version)))
 | |
| 
 | |
| 	for _, dbType := range setting.SupportedDatabaseTypes {
 | |
| 		assert.NoError(t, db.DumpDatabase(filepath.Join(dir, dbType+".sql"), dbType))
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestDeleteOrphanedObjects(t *testing.T) {
 | |
| 	assert.NoError(t, unittest.PrepareTestDatabase())
 | |
| 
 | |
| 	countBefore, err := db.GetEngine(db.DefaultContext).Count(&issues_model.PullRequest{})
 | |
| 	assert.NoError(t, err)
 | |
| 
 | |
| 	_, err = db.GetEngine(db.DefaultContext).Insert(&issues_model.PullRequest{IssueID: 1000}, &issues_model.PullRequest{IssueID: 1001}, &issues_model.PullRequest{IssueID: 1003})
 | |
| 	assert.NoError(t, err)
 | |
| 
 | |
| 	orphaned, err := db.CountOrphanedObjects("pull_request", "issue", "pull_request.issue_id=issue.id")
 | |
| 	assert.NoError(t, err)
 | |
| 	assert.EqualValues(t, 3, orphaned)
 | |
| 
 | |
| 	err = db.DeleteOrphanedObjects("pull_request", "issue", "pull_request.issue_id=issue.id")
 | |
| 	assert.NoError(t, err)
 | |
| 
 | |
| 	countAfter, err := db.GetEngine(db.DefaultContext).Count(&issues_model.PullRequest{})
 | |
| 	assert.NoError(t, err)
 | |
| 	assert.EqualValues(t, countBefore, countAfter)
 | |
| }
 |