mirror of
				https://gitcode.com/gitea/gitea.git
				synced 2025-10-26 05:04:27 +08:00 
			
		
		
		
	 61ad4c607b
			
		
	
	61ad4c607b
	
	
	
		
			
			minio storage iterator shows different behavior with local fs iterator.
in local fs storage:
``` go
s.IterateObjects("prefix", func(path,obj)
     println(path) // show "prefix/xxx.file"
})
```
in minio storage:
```go
s.IterateObjects("prefix", func(path,obj)
     println(path) // show "xxx.file"
})
```
I think local fs is correct, minio use wrong `basePath` to trim storage
path prefix.
---------
Co-authored-by: Giteabot <teabot@gitea.io>
		
	
		
			
				
	
	
		
			50 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			50 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2023 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package storage
 | |
| 
 | |
| import (
 | |
| 	"bytes"
 | |
| 	"testing"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| func testStorageIterator(t *testing.T, typStr string, cfg interface{}) {
 | |
| 	l, err := NewStorage(typStr, cfg)
 | |
| 	assert.NoError(t, err)
 | |
| 
 | |
| 	testFiles := [][]string{
 | |
| 		{"a/1.txt", "a1"},
 | |
| 		{"/a/1.txt", "aa1"}, // same as above, but with leading slash that will be trim
 | |
| 		{"ab/1.txt", "ab1"},
 | |
| 		{"b/1.txt", "b1"},
 | |
| 		{"b/2.txt", "b2"},
 | |
| 		{"b/3.txt", "b3"},
 | |
| 		{"b/x 4.txt", "bx4"},
 | |
| 	}
 | |
| 	for _, f := range testFiles {
 | |
| 		_, err = l.Save(f[0], bytes.NewBufferString(f[1]), -1)
 | |
| 		assert.NoError(t, err)
 | |
| 	}
 | |
| 
 | |
| 	expectedList := map[string][]string{
 | |
| 		"a":           {"a/1.txt"},
 | |
| 		"b":           {"b/1.txt", "b/2.txt", "b/3.txt", "b/x 4.txt"},
 | |
| 		"":            {"a/1.txt", "b/1.txt", "b/2.txt", "b/3.txt", "b/x 4.txt", "ab/1.txt"},
 | |
| 		"/":           {"a/1.txt", "b/1.txt", "b/2.txt", "b/3.txt", "b/x 4.txt", "ab/1.txt"},
 | |
| 		"a/b/../../a": {"a/1.txt"},
 | |
| 	}
 | |
| 	for dir, expected := range expectedList {
 | |
| 		count := 0
 | |
| 		err = l.IterateObjects(dir, func(path string, f Object) error {
 | |
| 			defer f.Close()
 | |
| 			assert.Contains(t, expected, path)
 | |
| 			count++
 | |
| 			return nil
 | |
| 		})
 | |
| 		assert.NoError(t, err)
 | |
| 		assert.Len(t, expected, count)
 | |
| 	}
 | |
| }
 |