mirror of
				https://gitcode.com/gitea/gitea.git
				synced 2025-10-25 12:26:40 +08:00 
			
		
		
		
	 b9a97ccd0e
			
		
	
	b9a97ccd0e
	
	
	
		
			
			The old code is unnecessarily complex, and has many misuses. Old code "wraps" a lot, wrap wrap wrap, it's difficult to understand which kind of handler is used. The new code uses a general approach, we do not need to write all kinds of handlers into the "wrapper", do not need to wrap them again and again. New code, there are only 2 concepts: 1. HandlerProvider: `func (h any) (handlerProvider func (next) http.Handler)`, it can be used as middleware 2. Use HandlerProvider to get the final HandlerFunc, and use it for `r.Get()` And we can decouple the route package from context package (see the TODO). # FAQ ## Is `reflect` safe? Yes, all handlers are checked during startup, see the `preCheckHandler` comment. If any handler is wrong, developers could know it in the first time. ## Does `reflect` affect performance? No. https://github.com/go-gitea/gitea/pull/24080#discussion_r1164825901 1. This reflect code only runs for each web handler call, handler is far more slower: 10ms-50ms 2. The reflect is pretty fast (comparing to other code): 0.000265ms 3. XORM has more reflect operations already
		
			
				
	
	
		
			179 lines
		
	
	
		
			5.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			179 lines
		
	
	
		
			5.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2021 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package web
 | |
| 
 | |
| import (
 | |
| 	"bytes"
 | |
| 	"net/http"
 | |
| 	"net/http/httptest"
 | |
| 	"strconv"
 | |
| 	"testing"
 | |
| 
 | |
| 	chi "github.com/go-chi/chi/v5"
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| func TestRoute1(t *testing.T) {
 | |
| 	buff := bytes.NewBufferString("")
 | |
| 	recorder := httptest.NewRecorder()
 | |
| 	recorder.Body = buff
 | |
| 
 | |
| 	r := NewRoute()
 | |
| 	r.Get("/{username}/{reponame}/{type:issues|pulls}", func(resp http.ResponseWriter, req *http.Request) {
 | |
| 		username := chi.URLParam(req, "username")
 | |
| 		assert.EqualValues(t, "gitea", username)
 | |
| 		reponame := chi.URLParam(req, "reponame")
 | |
| 		assert.EqualValues(t, "gitea", reponame)
 | |
| 		tp := chi.URLParam(req, "type")
 | |
| 		assert.EqualValues(t, "issues", tp)
 | |
| 	})
 | |
| 
 | |
| 	req, err := http.NewRequest("GET", "http://localhost:8000/gitea/gitea/issues", nil)
 | |
| 	assert.NoError(t, err)
 | |
| 	r.ServeHTTP(recorder, req)
 | |
| 	assert.EqualValues(t, http.StatusOK, recorder.Code)
 | |
| }
 | |
| 
 | |
| func TestRoute2(t *testing.T) {
 | |
| 	buff := bytes.NewBufferString("")
 | |
| 	recorder := httptest.NewRecorder()
 | |
| 	recorder.Body = buff
 | |
| 
 | |
| 	hit := -1
 | |
| 
 | |
| 	r := NewRoute()
 | |
| 	r.Group("/{username}/{reponame}", func() {
 | |
| 		r.Group("", func() {
 | |
| 			r.Get("/{type:issues|pulls}", func(resp http.ResponseWriter, req *http.Request) {
 | |
| 				username := chi.URLParam(req, "username")
 | |
| 				assert.EqualValues(t, "gitea", username)
 | |
| 				reponame := chi.URLParam(req, "reponame")
 | |
| 				assert.EqualValues(t, "gitea", reponame)
 | |
| 				tp := chi.URLParam(req, "type")
 | |
| 				assert.EqualValues(t, "issues", tp)
 | |
| 				hit = 0
 | |
| 			})
 | |
| 
 | |
| 			r.Get("/{type:issues|pulls}/{index}", func(resp http.ResponseWriter, req *http.Request) {
 | |
| 				username := chi.URLParam(req, "username")
 | |
| 				assert.EqualValues(t, "gitea", username)
 | |
| 				reponame := chi.URLParam(req, "reponame")
 | |
| 				assert.EqualValues(t, "gitea", reponame)
 | |
| 				tp := chi.URLParam(req, "type")
 | |
| 				assert.EqualValues(t, "issues", tp)
 | |
| 				index := chi.URLParam(req, "index")
 | |
| 				assert.EqualValues(t, "1", index)
 | |
| 				hit = 1
 | |
| 			})
 | |
| 		}, func(resp http.ResponseWriter, req *http.Request) {
 | |
| 			if stop, err := strconv.Atoi(req.FormValue("stop")); err == nil {
 | |
| 				hit = stop
 | |
| 				resp.WriteHeader(http.StatusOK)
 | |
| 			}
 | |
| 		})
 | |
| 
 | |
| 		r.Group("/issues/{index}", func() {
 | |
| 			r.Get("/view", func(resp http.ResponseWriter, req *http.Request) {
 | |
| 				username := chi.URLParam(req, "username")
 | |
| 				assert.EqualValues(t, "gitea", username)
 | |
| 				reponame := chi.URLParam(req, "reponame")
 | |
| 				assert.EqualValues(t, "gitea", reponame)
 | |
| 				index := chi.URLParam(req, "index")
 | |
| 				assert.EqualValues(t, "1", index)
 | |
| 				hit = 2
 | |
| 			})
 | |
| 		})
 | |
| 	})
 | |
| 
 | |
| 	req, err := http.NewRequest("GET", "http://localhost:8000/gitea/gitea/issues", nil)
 | |
| 	assert.NoError(t, err)
 | |
| 	r.ServeHTTP(recorder, req)
 | |
| 	assert.EqualValues(t, http.StatusOK, recorder.Code)
 | |
| 	assert.EqualValues(t, 0, hit)
 | |
| 
 | |
| 	req, err = http.NewRequest("GET", "http://localhost:8000/gitea/gitea/issues/1", nil)
 | |
| 	assert.NoError(t, err)
 | |
| 	r.ServeHTTP(recorder, req)
 | |
| 	assert.EqualValues(t, http.StatusOK, recorder.Code)
 | |
| 	assert.EqualValues(t, 1, hit)
 | |
| 
 | |
| 	req, err = http.NewRequest("GET", "http://localhost:8000/gitea/gitea/issues/1?stop=100", nil)
 | |
| 	assert.NoError(t, err)
 | |
| 	r.ServeHTTP(recorder, req)
 | |
| 	assert.EqualValues(t, http.StatusOK, recorder.Code)
 | |
| 	assert.EqualValues(t, 100, hit)
 | |
| 
 | |
| 	req, err = http.NewRequest("GET", "http://localhost:8000/gitea/gitea/issues/1/view", nil)
 | |
| 	assert.NoError(t, err)
 | |
| 	r.ServeHTTP(recorder, req)
 | |
| 	assert.EqualValues(t, http.StatusOK, recorder.Code)
 | |
| 	assert.EqualValues(t, 2, hit)
 | |
| }
 | |
| 
 | |
| func TestRoute3(t *testing.T) {
 | |
| 	buff := bytes.NewBufferString("")
 | |
| 	recorder := httptest.NewRecorder()
 | |
| 	recorder.Body = buff
 | |
| 
 | |
| 	hit := -1
 | |
| 
 | |
| 	m := NewRoute()
 | |
| 	r := NewRoute()
 | |
| 	r.Mount("/api/v1", m)
 | |
| 
 | |
| 	m.Group("/repos", func() {
 | |
| 		m.Group("/{username}/{reponame}", func() {
 | |
| 			m.Group("/branch_protections", func() {
 | |
| 				m.Get("", func(resp http.ResponseWriter, req *http.Request) {
 | |
| 					hit = 0
 | |
| 				})
 | |
| 				m.Post("", func(resp http.ResponseWriter, req *http.Request) {
 | |
| 					hit = 1
 | |
| 				})
 | |
| 				m.Group("/{name}", func() {
 | |
| 					m.Get("", func(resp http.ResponseWriter, req *http.Request) {
 | |
| 						hit = 2
 | |
| 					})
 | |
| 					m.Patch("", func(resp http.ResponseWriter, req *http.Request) {
 | |
| 						hit = 3
 | |
| 					})
 | |
| 					m.Delete("", func(resp http.ResponseWriter, req *http.Request) {
 | |
| 						hit = 4
 | |
| 					})
 | |
| 				})
 | |
| 			})
 | |
| 		})
 | |
| 	})
 | |
| 
 | |
| 	req, err := http.NewRequest("GET", "http://localhost:8000/api/v1/repos/gitea/gitea/branch_protections", nil)
 | |
| 	assert.NoError(t, err)
 | |
| 	r.ServeHTTP(recorder, req)
 | |
| 	assert.EqualValues(t, http.StatusOK, recorder.Code)
 | |
| 	assert.EqualValues(t, 0, hit)
 | |
| 
 | |
| 	req, err = http.NewRequest("POST", "http://localhost:8000/api/v1/repos/gitea/gitea/branch_protections", nil)
 | |
| 	assert.NoError(t, err)
 | |
| 	r.ServeHTTP(recorder, req)
 | |
| 	assert.EqualValues(t, http.StatusOK, recorder.Code, http.StatusOK)
 | |
| 	assert.EqualValues(t, 1, hit)
 | |
| 
 | |
| 	req, err = http.NewRequest("GET", "http://localhost:8000/api/v1/repos/gitea/gitea/branch_protections/master", nil)
 | |
| 	assert.NoError(t, err)
 | |
| 	r.ServeHTTP(recorder, req)
 | |
| 	assert.EqualValues(t, http.StatusOK, recorder.Code)
 | |
| 	assert.EqualValues(t, 2, hit)
 | |
| 
 | |
| 	req, err = http.NewRequest("PATCH", "http://localhost:8000/api/v1/repos/gitea/gitea/branch_protections/master", nil)
 | |
| 	assert.NoError(t, err)
 | |
| 	r.ServeHTTP(recorder, req)
 | |
| 	assert.EqualValues(t, http.StatusOK, recorder.Code)
 | |
| 	assert.EqualValues(t, 3, hit)
 | |
| 
 | |
| 	req, err = http.NewRequest("DELETE", "http://localhost:8000/api/v1/repos/gitea/gitea/branch_protections/master", nil)
 | |
| 	assert.NoError(t, err)
 | |
| 	r.ServeHTTP(recorder, req)
 | |
| 	assert.EqualValues(t, http.StatusOK, recorder.Code)
 | |
| 	assert.EqualValues(t, 4, hit)
 | |
| }
 |