6 Commits

Author	SHA1	Message	Date
Lunny Xiao	6433ba0ec3	Move macaron to chi (#14293) ... Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>	2021-01-26 16:36:53 +01:00	octicon-copy(16/) octicon-file-diff(16/) octicon-file-code(16/)
WGH	6ddd3b0b47	Implement webhook branch filter (#7791) ... * Fix validate() function to handle errors in embedded anon structs * Implement webhook branch filter See #2025, #3998.	2019-09-09 08:48:21 +03:00	octicon-copy(16/) octicon-file-diff(16/) octicon-file-code(16/)
Tamal Saha	171b359877	Use gitea forked macaron (#7933) ... Signed-off-by: Tamal Saha <tamal@appscode.com>	2019-08-23 12:40:29 -04:00	octicon-copy(16/) octicon-file-diff(16/) octicon-file-code(16/)
WGH	98fd085039	Fix lax comparison in validation tests (#7815) ... If you add t.Logf("%+v %+v", actual, testCase.expectedErrors) to the test code, you'll notice that only Errors' Messages are being compared: --- PASS: Test_ValidURLValidation/Invalid_schema (0.00s) binding_test.go:43: [Url] [Url] FieldNames and Classification are ignored in comparison. Moreover, an Errors slice with a single Error with empty message is formatted as '[]' (the same as empty slice), which is also error-prone. I discovered this when working on #7791 when one test which was not supposed to pass did pass. https://play.golang.org/p/qC4wVLrm4NG This commit changes the test to do the comparison properly.	2019-08-12 10:17:25 +08:00	octicon-copy(16/) octicon-file-diff(16/) octicon-file-code(16/)
kolaente	f9ec2f89f2	Add golangci (#6418)	2019-06-12 15:41:28 -04:00	octicon-copy(16/) octicon-file-diff(16/) octicon-file-code(16/)
Lauris BH	f42ec6120e	Better URL validation (#1507) ... * Add correct git branch name validation * Change git refname validation error constant name * Implement URL validation based on GoLang url.Parse method * Backward compatibility with older Go compiler * Add git reference name validation unit tests * Remove unused variable in unit test * Implement URL validation based on GoLang url.Parse method * Backward compatibility with older Go compiler * Add url validation unit tests	2017-04-19 11:02:20 +08:00	octicon-copy(16/) octicon-file-diff(16/) octicon-file-code(16/)