6 Commits

Author	SHA1	Message	Date
silverwind	19b017f398	Use explicit jQuery import, remove unused eslint globals (#18435) ... - Don't rely on globals (window.$) for jQuery import - Remove eslint globals no longer in use	2022-01-28 21:00:11 +00:00	octicon-copy(16/) octicon-file-diff(16/) octicon-file-code(16/)
wxiaoguang	0a9fcf63a4	Clean legacy SimpleMDE code (#17926) ... Since we are using EasyMDE now, we do not need to keep the SimpleMDE code anymore. This PR removes all legacy SimpleMDE code, and makes some related changes: * `createCommentEasyMDE` can accept native DOM element, and it doesn't need `jQuery.data` to store EasyMDE editor object (as discussed about the frontend guideline). * introduce `getAttachedEasyMDE` to get the attached EasyMDE editor object, it's easier to find all the usage of EasyMDE. * rename variable names from `$simplemde` to `easyMDE`, the `$` was incorrect because it is a EasyMDE editor, not a jQuery object. With this PR, it will be easier to do more refactoring or replacing EasyMDE with other editors.	2021-12-10 10:51:27 +08:00	octicon-copy(16/) octicon-file-diff(16/) octicon-file-code(16/)
silverwind	a159c3175f	Add new JS linter rules (#17699) ... * Add new JS linter rules Adds a few useful rules from eslint-plugin-github. Notable changes: - Forbid dataset usage, its camel-casing behaviour makes it hard to grep for attributes. - Forbid .then() and .catch(), we should generally prefer await for new code. For rare cases where they are useful, a eslint-disable-line directive can be set. - Add docs js to linting * also enable github/array-foreach * small tweak Co-authored-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2021-11-22 16:19:01 +08:00	octicon-copy(16/) octicon-file-diff(16/) octicon-file-code(16/)
zeripath	513951bc16	Remove appSubUrl from pasted images (#17572) ... * Remove appSubUrl from pasted images Since we fixed the url base for the links in repositories we no longer need to add the appsuburl to pasted image links. Fix #17057 Signed-off-by: Andrew Thornton <art27@cantab.net>	2021-11-08 14:27:40 +08:00	octicon-copy(16/) octicon-file-diff(16/) octicon-file-code(16/)
wxiaoguang	2add8fe9be	Frontend refactor, PascalCase to camelCase, remove unused code (#17365) ... * Frontend refactor, PascalCase to camelCase, remove unused code * fix	2021-10-21 15:37:43 +08:00	octicon-copy(16/) octicon-file-diff(16/) octicon-file-code(16/)
wxiaoguang	1a7473ff45	Split index.js to separate files (#17315) ... * split `index.js` to separate files * tune clipboard * fix promise * fix document * remove intermediate empty file * fix async event listener * use `export function` instead of `export {}`, add more comments Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: 6543 <6543@obermui.de>	2021-10-17 01:28:04 +08:00	octicon-copy(16/) octicon-file-diff(16/) octicon-file-code(16/)