opensource/gitea
1
0
Fork 0
mirror of https://gitcode.com/gitea/gitea.git synced 2025-08-06 01:37:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

Caller should check the ResponseExtra.HasError() first to see whether the request fails (#28796)

Browse Source 
`resp != nil` doesn't mean the request really succeeded. Add a comment
for requestJSONResp to clarify the behavior.
This commit is contained in:
wxiaoguang
2024-01-15 19:15:31 +08:00
committed by GitHub
parent 637451a45e
commit b0e6c25535
4 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/private/actions.go
View File

@ -22,7 +22,7 @@ func GenerateActionsRunnerToken(ctx context.Context, scope string) (string, Resp
})
resp, extra := requestJSONResp(req, &responseText{})
if resp == nil {
if extra.HasError() {
return "", extra
}
return resp.Text, extra