opensource/gitea
1
0
Fork 0
mirror of https://gitcode.com/gitea/gitea.git synced 2025-05-28 21:41:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Less naked returns (#25713)

Browse Source 
just a step towards  #25655

and some related refactoring
This commit is contained in:
6543
2023-07-07 07:31:56 +02:00
committed by GitHub
parent b1eb1676aa
commit 8995046110
32 changed files with 254 additions and 239 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
services/issue/assignee.go
View File

@ -46,13 +46,12 @@ func DeleteNotPassedAssignee(ctx context.Context, issue *issues_model.Issue, doe
func ToggleAssignee(ctx context.Context, issue *issues_model.Issue, doer *user_model.User, assigneeID int64) (removed bool, comment *issues_model.Comment, err error) {
removed, comment, err = issues_model.ToggleIssueAssignee(ctx, issue, doer, assigneeID)
if err != nil {
return
return false, nil, err
}
assignee, err1 := user_model.GetUserByID(ctx, assigneeID)
if err1 != nil {
err = err1
return
assignee, err := user_model.GetUserByID(ctx, assigneeID)
if err != nil {
return false, nil, err
}
notification.NotifyIssueChangeAssignee(ctx, doer, issue, assignee, removed, comment)
@ -236,23 +235,23 @@ func TeamReviewRequest(ctx context.Context, issue *issues_model.Issue, doer *use
}
if err != nil {
return
return nil, err
}
if comment == nil || !isAdd {
return
return nil, nil
}
// notify all user in this team
if err = comment.LoadIssue(ctx); err != nil {
return
if err := comment.LoadIssue(ctx); err != nil {
return nil, err
}
members, err := organization.GetTeamMembers(ctx, &organization.SearchMembersOptions{
TeamID: reviewer.ID,
})
if err != nil {
return
return nil, err
}
for _, member := range members {