opensource/gitea
1
0
Fork 0
mirror of https://gitcode.com/gitea/gitea.git synced 2025-06-20 03:43:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

Return 400 but not 500 when request archive with wrong format (#17691)

Browse Source
This commit is contained in:
Lunny Xiao
2021-11-18 03:47:35 +08:00
committed by GitHub
parent d8a8961b99
commit 81a4fc7528
4 changed files with 80 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
services/archiver/archiver_test.go
View File

@ -5,6 +5,7 @@
package archiver
import (
"errors"
"path/filepath"
"testing"
"time"
@ -19,10 +20,6 @@ func TestMain(m *testing.M) {
unittest.MainTest(m, filepath.Join("..", ".."))
}
func waitForCount(t *testing.T, num int) {
}
func TestArchive_Basic(t *testing.T) {
assert.NoError(t, unittest.PrepareTestDatabase())
@ -83,11 +80,8 @@ func TestArchive_Basic(t *testing.T) {
inFlight[2] = secondReq
ArchiveRepository(zipReq)
waitForCount(t, 1)
ArchiveRepository(tgzReq)
waitForCount(t, 2)
ArchiveRepository(secondReq)
waitForCount(t, 3)
// Make sure sending an unprocessed request through doesn't affect the queue
// count.
@ -132,3 +126,8 @@ func TestArchive_Basic(t *testing.T) {
assert.NotEqual(t, zipReq.GetArchiveName(), tgzReq.GetArchiveName())
assert.NotEqual(t, zipReq.GetArchiveName(), secondReq.GetArchiveName())
}
func TestErrUnknownArchiveFormat(t *testing.T) {
var err = ErrUnknownArchiveFormat{RequestFormat: "master"}
assert.True(t, errors.Is(err, ErrUnknownArchiveFormat{}))
}