opensource/gitea
1
0
Fork 0
mirror of https://gitcode.com/gitea/gitea.git synced 2025-08-06 01:37:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

prefer NoError/Error over Nil/NotNil (#12271)

Browse Source
This commit is contained in:
Stephen Solka
2020-07-19 05:53:40 -04:00
committed by GitHub
parent b609a25014
commit 54513452a1
11 changed files with 34 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/webhook/dingtalk_test.go
View File

@ -17,14 +17,14 @@ func TestGetDingTalkIssuesPayload(t *testing.T) {
p.Action = api.HookIssueOpened
pl, err := getDingtalkIssuesPayload(p)
require.Nil(t, err)
require.NoError(t, err)
require.NotNil(t, pl)
assert.Equal(t, "#2 crash", pl.ActionCard.Title)
assert.Equal(t, "[test/repo] Issue opened: #2 crash by user1\r\n\r\n", pl.ActionCard.Text)
p.Action = api.HookIssueClosed
pl, err = getDingtalkIssuesPayload(p)
require.Nil(t, err)
require.NoError(t, err)
require.NotNil(t, pl)
assert.Equal(t, "#2 crash", pl.ActionCard.Title)
assert.Equal(t, "[test/repo] Issue closed: #2 crash by user1\r\n\r\n", pl.ActionCard.Text)