mirror of
https://gitcode.com/gitea/gitea.git
synced 2025-06-01 15:55:15 +08:00
Clarify path param naming (#32969)
In history (from some legacy frameworks), both `:name` and `name` are supported as path path name, `:name` is an alias to `name`. To make code consistent, now we should only use `name` but not `:name`. Also added panic check in related functions to make sure the name won't be abused in case some downstreams still use them.
This commit is contained in:
@ -235,3 +235,9 @@ func checkOverlappedPath(name, path string) {
|
||||
}
|
||||
configuredPaths[path] = name
|
||||
}
|
||||
|
||||
func PanicInDevOrTesting(msg string, a ...any) {
|
||||
if !IsProd || IsInTesting {
|
||||
panic(fmt.Sprintf(msg, a...))
|
||||
}
|
||||
}
|
||||
|
@ -331,7 +331,5 @@ func QueryBuild(a ...any) template.URL {
|
||||
}
|
||||
|
||||
func panicIfDevOrTesting() {
|
||||
if !setting.IsProd || setting.IsInTesting {
|
||||
panic("legacy template functions are for backward compatibility only, do not use them in new code")
|
||||
}
|
||||
setting.PanicInDevOrTesting("legacy template functions are for backward compatibility only, do not use them in new code")
|
||||
}
|
||||
|
Reference in New Issue
Block a user