opensource/gin
1
0
Fork 0
mirror of https://github.com/gin-gonic/gin.git synced 2025-08-06 07:40:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't log requests (#1370)

Browse Source 
Fixes #1331

HTTP logging leaks sensitive request information.

This PR removes HTTP request logging during panics.
This commit is contained in:
Dustin Decker
2018-09-23 00:15:23 -07:00
committed by Bo-Yi Wu
parent 5a75dc7127
commit ad53619b15
2 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
recovery_test.go
View File

@ -24,9 +24,19 @@ func TestPanicInHandler(t *testing.T) {
w := performRequest(router, "GET", "/recovery")
// TEST
assert.Equal(t, http.StatusInternalServerError, w.Code)
assert.Contains(t, buffer.String(), "GET /recovery")
assert.Contains(t, buffer.String(), "panic recovered")
assert.Contains(t, buffer.String(), "Oupps, Houston, we have a problem")
assert.Contains(t, buffer.String(), "TestPanicInHandler")
assert.NotContains(t, buffer.String(), "GET /recovery")
// Debug mode prints the request
SetMode(DebugMode)
// RUN
w = performRequest(router, "GET", "/recovery")
// TEST
assert.Equal(t, http.StatusInternalServerError, w.Code)
assert.Contains(t, buffer.String(), "GET /recovery")
}
// TestPanicWithAbort assert that panic has been recovered even if context.Abort was used.