From dd4940a9034ff3a35ade3c0af033aa9dbdbdae53 Mon Sep 17 00:00:00 2001
From: Mickael KERJEAN <mickael.kerjean@gmail.com>
Date: Mon, 14 May 2018 18:24:51 +1000
Subject: [PATCH] improvement (S3): hide secret access key by default + auth
 bugfix - #58

---
 client/pages/connectpage/form.js | 4 +++-
 server/model/backend/s3.js       | 5 ++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/client/pages/connectpage/form.js b/client/pages/connectpage/form.js
index 38dcd48e..9f4f741e 100644
--- a/client/pages/connectpage/form.js
+++ b/client/pages/connectpage/form.js
@@ -92,7 +92,8 @@ export class Form extends React.Component {
         let credentials = Object.assign({}, this.props.credentials);
         for(let key in this.state.refs){
             if(this.state.refs[key]){
-                let [type, name] = key.split('_');
+                let [type, ...name] = key.split('_');
+                name = name.join("_");
                 if(!credentials[type]) credentials[type] = {};
                 credentials[type][name] = this.state.refs[key].ref.value;
             }
@@ -146,6 +147,7 @@ export class Form extends React.Component {
         else if(typeof value === 'number') return 'hidden';
         else if(value === false) return 'hidden';
         else if(key === 'password') return 'password';
+        else if(key === 'secret_access_key') return 'password';
         else{
             return 'text';
         }
diff --git a/server/model/backend/s3.js b/server/model/backend/s3.js
index 797d2f48..c2231079 100644
--- a/server/model/backend/s3.js
+++ b/server/model/backend/s3.js
@@ -15,10 +15,9 @@ function connect(params){
         apiVersion: '2006-03-01',
         accessKeyId: params.access_key_id,
         secretAccessKey: params.secret_access_key,
-        region: params.region,
         sslEnabled: true
-    });    
-    return Promise.resolve(s3);    
+    });
+    return Promise.resolve(s3);
 }
 
 module.exports = {