opensource/code-server
1
0
Fork 0
mirror of https://github.com/coder/code-server.git synced 2025-09-18 02:03:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix port parseInt error handling

Browse Source 
parseInt returns NaN rather than throwing.
This commit is contained in:
Asher
2025-05-08 14:20:45 -08:00
parent 2c9b4e7fd5
commit 9bd3b83ef5
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/node/routes/pathProxy.ts
View File

@ -13,10 +13,8 @@ const getProxyTarget = (
): string => { ): string => {
// If there is a base path, strip it out. // If there is a base path, strip it out.
const base = (req as any).base || "" const base = (req as any).base || ""
let port: number const port = parseInt(req.params.port, 10)
try { if (isNaN(port)) {
port = parseInt(req.params.port, 10)
} catch (err) {
throw new HttpError("Invalid port", HttpCode.BadRequest) throw new HttpError("Invalid port", HttpCode.BadRequest)
} }
return `http://0.0.0.0:${port}${opts?.proxyBasePath || ""}/${req.originalUrl.slice(base.length)}` return `http://0.0.0.0:${port}${opts?.proxyBasePath || ""}/${req.originalUrl.slice(base.length)}`