From 9012ddfe79ceba28d0e38a8f38dc4590e54ffdf8 Mon Sep 17 00:00:00 2001 From: Joe Previte Date: Mon, 12 Dec 2022 15:03:07 -0700 Subject: [PATCH] refactor: use separate cache key in release, run standalone after caching (#5859) * refactor: remove keytar dep in cross-compile * refactor: try other keytar package * refactor: remove keytar step in cross-compile * fix: manually remove keytar * try this first * I think this is it * Revert "I think this is it" This reverts commit 5c566b0c0126da1d3baa2f3c69e26fe1cc63fe93. * okay this is it * fixup * try legacy peer * remove keytar before standalone * wrong path * maybe * revert: change *npm* back to npm* * revert: don't uninstall keytar * fix: use npm run standalone-release * fixup formatting * Revert "refactor: remove yarn.lock steps (#5850)" This reverts commit 907747d3949301d8836e71938940f6275b016062. * fixup: remove the --exclude * refactor: remove yarn.lock check * try ddd in postinstall * refactor: cache before release:standalone * refactor: add os to cache key in release * chore: formatting * Update ci/build/npm-postinstall.sh * fixup: formatting --- .github/workflows/release.yaml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index b492a4417..5ba764c44 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -67,19 +67,19 @@ jobs: - name: Decompress npm package run: tar -xzf package.tar.gz - # NOTE: && here is deliberate - GitHub puts each line in its own `.sh` - # file when running inside a docker container. - - name: Build standalone release - run: source scl_source enable devtoolset-9 && npm run release:standalone - - name: Fetch dependencies from cache id: cache-node-modules uses: actions/cache@v3 with: path: "**/node_modules" - key: yarn-build-${{ hashFiles('**/yarn.lock') }} + key: yarn-build-linux-amd64-${{ hashFiles('**/yarn.lock') }} restore-keys: | - yarn-build- + yarn-build-linux-amd64- + + # NOTE: && here is deliberate - GitHub puts each line in its own `.sh` + # file when running inside a docker container. + - name: Build standalone release + run: source scl_source enable devtoolset-9 && npm run release:standalone - name: Install test dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true' @@ -237,17 +237,17 @@ jobs: - name: Decompress npm package run: tar -xzf package.tar.gz - - name: Build standalone release - run: npm run release:standalone - - name: Fetch dependencies from cache id: cache-node-modules uses: actions/cache@v3 with: path: "**/node_modules" - key: yarn-build-${{ hashFiles('**/yarn.lock') }} + key: yarn-build-macos-${{ hashFiles('**/yarn.lock') }} restore-keys: | - yarn-build- + yarn-build-macos- + + - name: Build standalone release + run: npm run release:standalone - name: Install test dependencies if: steps.cache-node-modules.outputs.cache-hit != 'true'