opensource/code-server
1
0
Fork 0
mirror of https://github.com/coder/code-server.git synced 2025-07-29 04:52:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary return types

Browse Source
This commit is contained in:
Asher
2020-03-11 16:00:39 -05:00
parent f6a5eaa965
commit 253cf1c438
3 changed files with 7 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/node/http.ts
View File

@ -147,14 +147,14 @@ export abstract class HttpProvider {
_socket: net.Socket,
_head: Buffer,
/* eslint-enable @typescript-eslint/no-unused-vars */
): Promise<true | undefined> {
): Promise<void> {
throw new HttpError("Not found", HttpCode.NotFound)
}
/**
* Handle requests to the registered endpoint.
*/
public abstract handleRequest(route: Route, request: http.IncomingMessage): Promise<HttpResponse | undefined>
public abstract handleRequest(route: Route, request: http.IncomingMessage): Promise<HttpResponse>
/**
* Get the base relative to the provided route. For each slash we need to go
@ -529,9 +529,6 @@ export class HttpServer {
const route = this.parseUrl(request)
try {
const payload = this.maybeRedirect(request, route) || (await route.provider.handleRequest(route, request))
if (!payload) {
throw new HttpError("Not found", HttpCode.NotFound)
}
response.writeHead(payload.redirect ? HttpCode.Redirect : payload.code || HttpCode.Ok, {
"Content-Type": payload.mime || getMediaMime(payload.filePath),
...(payload.redirect ? { Location: this.constructRedirect(request, route, payload as RedirectResponse) } : {}),
@ -633,11 +630,7 @@ export class HttpServer {
throw new HttpError("Not found", HttpCode.NotFound)
}
if (
!(await route.provider.handleWebSocket(route, request, await this.socketProvider.createProxy(socket), head))
) {
throw new HttpError("Not found", HttpCode.NotFound)
}
await route.provider.handleWebSocket(route, request, await this.socketProvider.createProxy(socket), head)
} catch (error) {
socket.destroy(error)
logger.warn(`discarding socket connection: ${error.message}`)