a706163966
Bugfix: regression introduced in revision 1104 - Abort()ing in popupTreeView causes various misbehaviours.
...
Also added three debug statements so the rest of you can test and see that things happen in the right order now; feel free to remove these.
2007-11-08 12:10:37 +00:00
c8d8712a89
Fix bug #1827494 import csv file field terminated by not working
2007-11-07 19:01:02 +00:00
95125c1861
TTreeNode.AbsoluteIndex did not work exactly as I had imagined. With this patch we're back to right-click + refresh in tree view being unstable, in fact with the exact same exception as before. (But at least it should be easier to debug now.)
2007-11-07 12:09:59 +00:00
5f86b11cad
* Bugfix: The TTreeView component has a nasty habit of inserting a bad memory reference into TTreeView.Selected whenever TTreeView.ClearSelection() or TTreeView.Items.Clear() are called. The bad memory reference is in turn picked up by GetActiveDatabase and GetSelectedTable, which are used all over the place, making stuff like this fun to debug. Worked around by constructing a 'fake' db tree in memory, then prodding the TTreeNodes structure from that on top of the regular DB tree. Someone bothered to do a bit of serialization / deserialization magic in TTreeNodes.Assign, making this work beautifully.
...
* Bugfix: When methods are called recursively, they should push/pop altered event handlers on a LIFO stack instead of blindly setting and unsetting them.
* Cosmetic: Reclaim screen real estate in ReadDatabasesAndTables().
2007-11-07 07:02:10 +00:00
a8c01d8f77
* Bugfix: node.Selected := true and tree.Selected := node is not the same, for some reason.
...
* Bugfix: Some state changes (tree.Selected) did not correctly take effect when tree.Items.{Begin,End}Update was used, causing an exception later on in GetSelectedTable, GetActiveDatabase etc.
To reproduce the bug, right-click a table, drop it, then right-click another table in same database and choose "refresh".
2007-11-06 14:53:12 +00:00
fcc066d3e0
Follow-up to r1103: Enable keys before unlocking the table, so things are done in reverse to the locking process.
2007-11-06 14:20:11 +00:00
62eb57abf1
Follow-up to r1104: popup menu entry click event handlers are invoked via window messages, sigh.
2007-11-06 14:19:21 +00:00
508bd4c96d
Oops, forgot to check before committing. This line should not have been part of the last commit.
2007-11-06 13:38:22 +00:00
90035256ec
Bugfix: Fix a whole slew of access violations when various routines try to read memory referenced by DBRightClickSelectedItem but already released (or reused). For example, the recurring AVs when opening the 'export tables' dialog.
2007-11-06 13:33:20 +00:00
6d326739c2
Bugfix: LOCK TABLES needs to be done before DISABLE KEYS. MySQL seemingly does not always enforce this correctly? Either way, it's the correct semantics, to prevent other writers leaving data in the table after keys has been disabled but before HeidiSQL locks it.
2007-11-06 13:07:39 +00:00
65cfbd462d
Add user preference to disable snipping of long log lines. While it conserves memory, it is undesirable if you are debugging.
...
(Changed to help andipfaff troubleshoot issue #1815148.)
2007-11-06 12:48:31 +00:00
2220a2c081
Bugfix: Prevents the change of delimiter on focus query editor.
2007-11-06 04:34:06 +00:00
f0bc98f305
Fix bug #1826253 "Too easy to change delimiter by accident"
2007-11-06 04:22:48 +00:00
7cc7007de1
Fix one memory leak in threaded queries (detected by testing and comparing, using taskmanager)
2007-11-04 13:23:47 +00:00
a42a84ff6e
Fix bug #1819886 "export silently overwrites target files" by later prompting for overwriting the target file.
2007-10-28 13:01:02 +00:00
d3529fd37d
Fix bug #1820595 "Access violation in manage indexes"
2007-10-28 12:39:04 +00:00
22f5af0f8b
Fix bug #1820597 "Can't delete the last index of a table"
2007-10-28 12:25:31 +00:00
9b90e38572
Fix bug #1685799 "interface allows selecting zerofill without unsigned"
2007-10-28 12:01:34 +00:00
382af79afc
Fix issue #1819883 .
2007-10-25 13:32:24 +00:00
e6977624cc
My IDE seems quite eager to remove this property. Anybody using it?
2007-10-24 14:13:56 +00:00
0a3f6abdf9
Add a light "progress bar" to the percentage column of ListCommandStats to visualize the amount of the commands.
2007-10-23 22:58:20 +00:00
07be7a7222
GUI specific initializings and restoring registry settings belongs to ReadWindowOptions. So, move all two lines from FormCreate here.
2007-10-23 21:40:18 +00:00
edbfbedc2f
Hide columns in ListTables if their header was "draggedout", which means: dragged up or down, not to the left or right.
2007-10-23 21:29:20 +00:00
cbc37695de
Minor: Add/update documentation for MakeFloat
2007-10-23 19:00:54 +00:00
f085be1ca8
Rename mysql.pas and it's helper file installer_function_list_generator.php so their purpose is more clearer to newbies.
2007-10-23 18:49:14 +00:00
13e925b9fa
Bugfix: Quick fix for multiple access violations in filter code, as described in issue #1704044 .
2007-10-23 12:52:37 +00:00
88076cd475
Cosmetic: clarify a comment.
2007-10-23 12:17:59 +00:00
6eb385689d
Change caption shown when fetching data fails.
2007-10-23 12:06:53 +00:00
7569a53c00
Fix memory leak when prefRememberFilters is false.
2007-10-23 10:59:35 +00:00
62e071693c
Renovate print dialog:
...
- Fix displaying generated checkboxes in hidden area by adjusting the form's height after generating the checkboxes.
- Apply 8px margins on all edges
- Replace printer bitmap by clearer TLabel saying "Select printer"
- Sanitize component names
- Rely on ModalResult of buttons and save a btnCancelClick procedure
2007-10-22 19:01:41 +00:00
a4406b229f
Fix a sorting bug in vstCompareNodes: Floats were always truncated to integers, then compared. So, sorting 0,1 and 0,2 placed these values somewhere between the 0 values.
...
- Introduce helper "MakeFloat" which does exactly the same as MakeInt except from truncating floats
- Use MakeFloat instead of MakeInt in vstCompareNodes to fix the above mentioned bug
2007-10-21 18:48:23 +00:00
e2e13aac42
Minor safety fix: Be sure status bar doesn't display old "db: xx tables".
2007-10-21 17:53:11 +00:00
ea8e9da577
Fix AV for usage on 5.1.22 servers when clicking on "information_schema": SHOW TABLE STATUS returns NULL in "Rows" column (rather than "0").
...
Fixes (last?) potential cause for bug #1772735 "unable to select a specific database"
Thanks to mdaems for the detailed bugreport via pm!
2007-10-16 20:10:31 +00:00
17f9730b76
Fix bugs
...
#1814411 "Incorrect SQL when changing structure on a field"
#1814293 "Incorrect SQL when changing structure on a FLOAT field"
2007-10-16 19:34:25 +00:00
0d0c0ddbef
Fix bug #1813760 "TIMESTAMP fields with NULL".
...
Side effect: Explicitely set "Can be NULL" option if "Not Null" is unchecked
2007-10-16 19:04:59 +00:00
7f901e325b
"Copy table" dialog: Use ensureValidIdentifier() to validate the name of the new table.
2007-10-12 19:27:39 +00:00
f3e98a9f5b
Fix bug #1810117 Updating timestamp fields with default value "CURRENT_TIMESTAMP"
2007-10-12 19:16:04 +00:00
a027d51276
Fix logic in TFieldEditForm.OkClick which lead to closing the fieldeditor with ModalResult=mrCancel after SQL errors, although AddUpdateField() sets mrNone.
2007-10-12 18:51:07 +00:00
b16a5184a9
Do not suppress SQL errors in case the field editor generated erroneous SQL.
2007-10-12 18:44:10 +00:00
a89b1df396
Fix a bug in threaded queries: The query thread sometimes didn't call SetThreadResult. (with a good hint from rosenfield).
...
Fixes at least two things:
- Rely on getting an exception when calling ExecUpdateQuery with erroneous SQL (fx the field editor does that sometimes when you update a TIMESTAMP field
- Executing queries from the query editor, receiving "Cannot perform this operation on a closed dataset"
2007-10-12 18:37:34 +00:00
0c611991e2
Fieldeditor GUI:
...
- Adjust position of controls
- Add shortcuts / focuscontrols
Seems like 8px is a good choice for margins to form edges.
2007-10-10 21:59:39 +00:00
db81b8af50
Save/Restore the DELIMITER list on Registry: must be BEFORE read/write the key Servers.
2007-10-10 18:39:27 +00:00
96002807d8
Save/Restore the DELIMITER list on Registry.
2007-10-10 18:33:51 +00:00
b7b652da67
Fix adjusting linenumbers in SQL log when user changed the max linecount in preferences.
2007-10-10 18:17:35 +00:00
22daed7044
Move include files to include directory.
2007-10-10 11:46:27 +00:00
29b951b843
* Add svnversion + envpipe + sed as part of build process, as a quick fix to get WC revision numbers into main.pas.
2007-10-09 16:39:57 +00:00
8002d0bd46
Minor GUI fix: Scroll and repaint SQL Log AFTER adjusting line numbers.
2007-10-08 22:07:21 +00:00
4232f36909
* Remove spam.
...
* Improve performance by not painting the progress form if a query completes within 300 msecs.
2007-10-08 21:52:59 +00:00
74074fe633
Bugfix: There is no thread safety mechanism in Zeos for the SQL log, so implement one in HeidiSQL. This should speed up async queries tremendously, as they no longer have to wait for the GUI to repaint before firing the actual query. Haven't bothered thinking about thread safety around the creation of the critical section protecting the TStringList, mainly because I'm infinitely annoyed by Delphi not providing a thread-safe list capable of holding lists OOTB..
2007-10-08 21:29:16 +00:00
3c5d236555
Bugfix: Don't try to access element -1 of a collection.
...
Please enable DEBUGGING in your builds so you can catch these sort of things before release time.
2007-10-08 16:56:43 +00:00
