Commit Graph

319 Commits

Author SHA1 Message Date
Ansgar Becker
db48c82110 Find a better fix for the black focus rectangle plus fix another graphical glitch for MEMO and BLOB cells, which didn't get covered completely by the (NULL). This fix just leaves the (MEMO) and only uses the grey color for it. 2007-12-05 00:36:03 +00:00
Ansgar Becker
367cb4cc40 Fix a minor graphical glitch when a focus rectangle is displayed in a gridcell (broken in rev 1156) 2007-12-05 00:12:49 +00:00
Ansgar Becker
42166f0975 Remove "Data always in edit mode" option again and setting that to False at designtime. (as discussed on the devels-mailinglist) 2007-12-04 23:51:41 +00:00
Ansgar Becker
d3307814b5 Followup to rev 668 and rev 678: Reenable option "Datagrids always in edit-mode". Implement a simple workaround for the broken copy+paste shortcuts. However, don't touch the TAction items Copy+Paste to avoid unpredictable behaviour. 2007-12-02 13:01:52 +00:00
Ansgar Becker
d6cda29f14 Add Nemanja (commandline parser) to authors list. Some GUI adjustments in the about window needed because that list got longer. 2007-12-02 07:52:04 +00:00
Ansgar Becker
23c13d2531 Cleanup usage of background colors in grids and listviews:
* TNTGrid is not capable of displaying a sort arrow in column titles. So, signalize sort direction of columns in grids and listviews by lightgrey (= ascending) and mediumgrey (= descending)
* Remove special color for NULL cells in grids because it can conflict with the new sorting colors. Instead, place a grey (NULL) text in these cells. Less gaudy colors now.
* Also remove grey background in primary key columns for the benefit of sorting colors. PK cells have bold font anyway, should be noticable enough.
2007-12-01 22:37:21 +00:00
Ansgar Becker
85faa5ffc3 Implement parser for connection parameters on commandline.
Code snippets by Nemanja, see discussion: http://www.heidisql.com/forum/viewtopic.php?t=252
2007-11-30 21:34:41 +00:00
rosenfield
8c0965166c Fix second part of issue #1839045: conditional around default charset winds on for too long, encapsulating "row_format" too. Lines 754-768 should probably be factored out into a general method for doing these conditionals. Hmm, and why are there different target MySQL versions when the export function generates multi-version SQL anyway? 2007-11-29 20:42:48 +00:00
rosenfield
92737fa072 When masking USING <indexing algorithm>, place the end of the conditional enclosing right after the name of the algorithm (at the first space. assuming the name is only one word), rather than after at the first comma or parenthesis. Fixes issue #1839045. 2007-11-29 20:36:49 +00:00
Ansgar Becker
f6d4e637e3 Replace TSMDBGrid in Data + Query tabs by TTntDBGrid.
- Implement an alternative solution for handling sorted columns without usage of SMDBGrid's sortcolumns. Move relevant structures and functions from data_sorting.pas to childwin.pas and use them in both units.
- Upgrade some code parts to use WideStrings instead of Strings so they don't break with the new grid.
- Use Grid.OnDrawDataCell as an alternative to Grid.OnGetCellParams as the latter one is a feature of SMDBGrid
- Cosmetic: enhance screen real estate in viewdata()
2007-11-26 20:58:08 +00:00
Ansgar Becker
415ef1d8c2 Fix bug #1832418 "access violation. no import" 2007-11-15 17:51:24 +00:00
Ansgar Becker
4107c21e1d Fix order of developers in aboutbox. Active members should be listed at the top. 2007-11-14 19:35:54 +00:00
rosenfield
0cc2bd5f7f Get rid of deprecated and platform symbols. 2007-11-09 12:14:25 +00:00
rosenfield
e7bcbdf293 * Bugfix: plug the most obvious memory leaks.
* Clear some unused code and wrong comments.
2007-11-09 09:51:31 +00:00
rosenfield
51c23000f9 Correct some code comments. 2007-11-09 07:59:14 +00:00
rosenfield
727e79aa33 Parameter checking is not useful here, at least not until Insert Files makes use of the query thread. 2007-11-09 07:55:10 +00:00
rosenfield
a706163966 Bugfix: regression introduced in revision 1104 - Abort()ing in popupTreeView causes various misbehaviours.
Also added three debug statements so the rest of you can test and see that things happen in the right order now; feel free to remove these.
2007-11-08 12:10:37 +00:00
Ansgar Becker
c8d8712a89 Fix bug #1827494 import csv file field terminated by not working 2007-11-07 19:01:02 +00:00
rosenfield
95125c1861 TTreeNode.AbsoluteIndex did not work exactly as I had imagined. With this patch we're back to right-click + refresh in tree view being unstable, in fact with the exact same exception as before. (But at least it should be easier to debug now.) 2007-11-07 12:09:59 +00:00
rosenfield
5f86b11cad * Bugfix: The TTreeView component has a nasty habit of inserting a bad memory reference into TTreeView.Selected whenever TTreeView.ClearSelection() or TTreeView.Items.Clear() are called. The bad memory reference is in turn picked up by GetActiveDatabase and GetSelectedTable, which are used all over the place, making stuff like this fun to debug. Worked around by constructing a 'fake' db tree in memory, then prodding the TTreeNodes structure from that on top of the regular DB tree. Someone bothered to do a bit of serialization / deserialization magic in TTreeNodes.Assign, making this work beautifully.
* Bugfix: When methods are called recursively, they should push/pop altered event handlers on a LIFO stack instead of blindly setting and unsetting them.

* Cosmetic: Reclaim screen real estate in ReadDatabasesAndTables().
2007-11-07 07:02:10 +00:00
rosenfield
a8c01d8f77 * Bugfix: node.Selected := true and tree.Selected := node is not the same, for some reason.
* Bugfix: Some state changes (tree.Selected) did not correctly take effect when tree.Items.{Begin,End}Update was used, causing an exception later on in GetSelectedTable, GetActiveDatabase etc.

To reproduce the bug, right-click a table, drop it, then right-click another table in same database and choose "refresh".
2007-11-06 14:53:12 +00:00
rosenfield
fcc066d3e0 Follow-up to r1103: Enable keys before unlocking the table, so things are done in reverse to the locking process. 2007-11-06 14:20:11 +00:00
rosenfield
62eb57abf1 Follow-up to r1104: popup menu entry click event handlers are invoked via window messages, sigh. 2007-11-06 14:19:21 +00:00
rosenfield
508bd4c96d Oops, forgot to check before committing. This line should not have been part of the last commit. 2007-11-06 13:38:22 +00:00
rosenfield
90035256ec Bugfix: Fix a whole slew of access violations when various routines try to read memory referenced by DBRightClickSelectedItem but already released (or reused). For example, the recurring AVs when opening the 'export tables' dialog. 2007-11-06 13:33:20 +00:00
rosenfield
6d326739c2 Bugfix: LOCK TABLES needs to be done before DISABLE KEYS. MySQL seemingly does not always enforce this correctly? Either way, it's the correct semantics, to prevent other writers leaving data in the table after keys has been disabled but before HeidiSQL locks it. 2007-11-06 13:07:39 +00:00
rosenfield
65cfbd462d Add user preference to disable snipping of long log lines. While it conserves memory, it is undesirable if you are debugging.
(Changed to help andipfaff troubleshoot issue #1815148.)
2007-11-06 12:48:31 +00:00
Francisco Ernesto Teixeira
2220a2c081 Bugfix: Prevents the change of delimiter on focus query editor. 2007-11-06 04:34:06 +00:00
Francisco Ernesto Teixeira
f0bc98f305 Fix bug #1826253 "Too easy to change delimiter by accident" 2007-11-06 04:22:48 +00:00
Ansgar Becker
7cc7007de1 Fix one memory leak in threaded queries (detected by testing and comparing, using taskmanager) 2007-11-04 13:23:47 +00:00
Ansgar Becker
a42a84ff6e Fix bug #1819886 "export silently overwrites target files" by later prompting for overwriting the target file. 2007-10-28 13:01:02 +00:00
Ansgar Becker
d3529fd37d Fix bug #1820595 "Access violation in manage indexes" 2007-10-28 12:39:04 +00:00
Ansgar Becker
22f5af0f8b Fix bug #1820597 "Can't delete the last index of a table" 2007-10-28 12:25:31 +00:00
Ansgar Becker
9b90e38572 Fix bug #1685799 "interface allows selecting zerofill without unsigned" 2007-10-28 12:01:34 +00:00
rosenfield
382af79afc Fix issue #1819883. 2007-10-25 13:32:24 +00:00
rosenfield
e6977624cc My IDE seems quite eager to remove this property. Anybody using it? 2007-10-24 14:13:56 +00:00
Ansgar Becker
0a3f6abdf9 Add a light "progress bar" to the percentage column of ListCommandStats to visualize the amount of the commands. 2007-10-23 22:58:20 +00:00
Ansgar Becker
07be7a7222 GUI specific initializings and restoring registry settings belongs to ReadWindowOptions. So, move all two lines from FormCreate here. 2007-10-23 21:40:18 +00:00
Ansgar Becker
edbfbedc2f Hide columns in ListTables if their header was "draggedout", which means: dragged up or down, not to the left or right. 2007-10-23 21:29:20 +00:00
Ansgar Becker
cbc37695de Minor: Add/update documentation for MakeFloat 2007-10-23 19:00:54 +00:00
Ansgar Becker
f085be1ca8 Rename mysql.pas and it's helper file installer_function_list_generator.php so their purpose is more clearer to newbies. 2007-10-23 18:49:14 +00:00
rosenfield
13e925b9fa Bugfix: Quick fix for multiple access violations in filter code, as described in issue #1704044. 2007-10-23 12:52:37 +00:00
rosenfield
88076cd475 Cosmetic: clarify a comment. 2007-10-23 12:17:59 +00:00
rosenfield
6eb385689d Change caption shown when fetching data fails. 2007-10-23 12:06:53 +00:00
rosenfield
7569a53c00 Fix memory leak when prefRememberFilters is false. 2007-10-23 10:59:35 +00:00
Ansgar Becker
62e071693c Renovate print dialog:
- Fix displaying generated checkboxes in hidden area by adjusting the form's height after generating the checkboxes.
- Apply 8px margins on all edges
- Replace printer bitmap by clearer TLabel saying "Select printer"
- Sanitize component names
- Rely on ModalResult of buttons and save a btnCancelClick procedure
2007-10-22 19:01:41 +00:00
Ansgar Becker
a4406b229f Fix a sorting bug in vstCompareNodes: Floats were always truncated to integers, then compared. So, sorting 0,1 and 0,2 placed these values somewhere between the 0 values.
- Introduce helper "MakeFloat" which does exactly the same as MakeInt except from truncating floats
- Use MakeFloat instead of MakeInt in vstCompareNodes to fix the above mentioned bug
2007-10-21 18:48:23 +00:00
Ansgar Becker
e2e13aac42 Minor safety fix: Be sure status bar doesn't display old "db: xx tables". 2007-10-21 17:53:11 +00:00
Ansgar Becker
ea8e9da577 Fix AV for usage on 5.1.22 servers when clicking on "information_schema": SHOW TABLE STATUS returns NULL in "Rows" column (rather than "0").
Fixes (last?) potential cause for bug #1772735 "unable to select a specific database"

Thanks to mdaems for the detailed bugreport via pm!
2007-10-16 20:10:31 +00:00
Ansgar Becker
17f9730b76 Fix bugs
#1814411 "Incorrect SQL when changing structure on a field"
#1814293 "Incorrect SQL when changing structure on a FLOAT field"
2007-10-16 19:34:25 +00:00