Commit Graph

5018 Commits

Author SHA1 Message Date
rosenfield
e57857c975 * Bugfix: Allow editing the 'fallback' password and privileges.
Note on verbiage:  I chose "Everybody" rather than "Everyone" or "Fallback" as the pretty name for this account.

"Fallback" just seemed like it was misplaced in the user dropdown list.

"Everyone" seems to mean individuals in a group, while "everybody" seems to mean the group as a whole.  Thus "everyone" is a bit more personal.

This could convey the notion that you need to have a personal account before these privileges will apply to you, which is not the case.  Anyone that logs in with a non-existent user name will get these privileges.

Therefore, "Everybody".  It hopefully denotes that the privileges are given to everyone with a personal account, PLUS people authenticating with a rubbish user name (and the password, if any).

This last category of logins are commonly called "anonymous users" in the MySQL documentation.  "Anonymous" does not quite fit this account however, because the privileges given also apply to everyone else.

* Bugfix: Copy + paste same text in the username field caused a warning.
2008-05-09 13:35:26 +00:00
rosenfield
9ca0cea574 Add two more icons: group {add,delete}. 2008-05-09 13:09:47 +00:00
rosenfield
e5a8981c66 Partial revert of r1348: restore the group edit icon, which is going to be used in a moment. 2008-05-09 12:49:09 +00:00
rosenfield
ec685f50b7 Bugfix: Host='' and Host='%' means the same. Canonicalization was in place here and there, but also missing in a couple of spots. 2008-05-09 12:38:56 +00:00
rosenfield
a0546a403d Bugfix: changing a limitation did not cause a 'modified' icon in the account dropdown. 2008-05-09 11:48:55 +00:00
rosenfield
d4ead47114 Flush privileges after apply. 2008-05-09 11:32:28 +00:00
rosenfield
45cc7920dd GUI: More vertical spacing between controls on 'limitations' page. (Revert if you think this is uglier.) 2008-05-09 11:25:08 +00:00
rosenfield
c9460f215e Bugfix: (gui) anchor hint text correctly. 2008-05-09 11:20:31 +00:00
Ansgar Becker
d4c32d56d7 Implement a completely new user manager (look + feel + logic):
- Accounts and existing privileges are presented in a pulldown which makes it as easy to use as a toy
- Adding privileges calls the new SelectDBO dialog which is basically a tree like childwins dbtree
- Updating accounts canonicalizes various odd/legacy mechanisms in the MySQL user system
- Fullfills feature request #1547437 (btw)
- Wants to be tested heavily on different servers

A result of a team work. 1000 thanks to rosenfield for the admin friendly logic implementation, tons of fixes and usability ideas.
2008-05-08 20:45:51 +00:00
rosenfield
54de398a1c Bugfix: Avoid scroll by removing blank line outside visible area in Authors text box. 2008-05-05 17:23:50 +00:00
Ansgar Becker
85f91d87aa Dynamically fetch names of privileges on the "Add user" tab of the usermanager, as discussed on the mailinglist.
TODO: Refactor complete GUI of this dialog, nuke tabs and do both adding and editing users in one GUI.
2008-04-16 15:34:51 +00:00
Ansgar Becker
712b52f27c PopulateTreeTableList: Tell what's currently being done via statusbar. This message message should be visible long enough only in rather rare situations with several 100 tables in a database. 2008-04-16 15:03:02 +00:00
Ansgar Becker
2be6d491ac Fix statusbar text updates while refreshing ListTables. Ensure "ready" message is displayed in the end. 2008-04-15 20:46:37 +00:00
Ansgar Becker
1c52b14e11 Get rid of "N/A" constant, consistently use empty an string where that was used. 2008-04-11 20:54:58 +00:00
Ansgar Becker
bba3d2afc1 Implement option to prefer SHOW TABLES over SHOW TABLES STATUS, as discussed on the mailing list. Fix relevant AVs and detection of VIEW/BASETABLE in GetDBObjectType (at least for 5.0.2+ servers). 2008-04-11 19:23:47 +00:00
Ansgar Becker
ece84cc5a8 Ensure main window (that means: the upper left corner) is placed inside current monitor resolution, important e.g. after having plugged off a second monitor. This ensures a minimum visible area of 80x80 pixels, giving the user the possibility to manually resize and move the window.
TODO: This only works if AutoReconnect is set to True. Do the same for the connection dialog which is the first window with AutoReconnect = False.
2008-04-05 12:58:57 +00:00
Ansgar Becker
10ea69ab93 Try to fix bug #1931387 "Hangs on large number of tables". Plus: Remove "find" parameter from PopulateTreeTableList procedure as that was used only once and there only to pass SelectedTable. 2008-04-05 11:34:48 +00:00
Ansgar Becker
c97111e759 Remove weird automatic column sizing as discussed in bug #1889628 . Fixes that bug. 2008-03-31 21:17:35 +00:00
Ansgar Becker
28634e67b3 Follow up to rev 1307: Also analyse table names in JOIN clauses for proposal pulldown.
Example: SELECT * FROM tab1 t1 LEFT JOIN tab2 AS t2 WHERE t2.[PULLDOWN!]
2008-03-31 17:57:04 +00:00
Ansgar Becker
a9a6d36cd6 Fix bug #1841345 by implementing a deeper analysis of the SQL in query editor. Using regular expressions now. Should cover more different situations where a table alias is used, e.g.
- including "AS" or not
- already masked tables/dbs or not masked
2008-03-30 18:31:27 +00:00
Ansgar Becker
c70bc467b1 Find a well working replacement for platform specific SelectDirectory function in StdActns unit. Fixes a corresponding compiler warning about using FileCtrl unit. 2008-03-29 17:09:51 +00:00
rosenfield
19f463b1d0 Code comments... 2008-03-29 16:13:31 +00:00
Ansgar Becker
55f9c91db3 Fix completion proposal for tab indented table and db names. The tab (#9) was counted to the table name. 2008-03-28 16:35:10 +00:00
Ansgar Becker
1410658712 Fix refresh of ListColumns after closing index manager. 2008-03-28 16:04:08 +00:00
Ansgar Becker
8226fae2be Kill option to manually specify value of initial limit (DataLimitEnd) in preferences. Keeping the checkbox for autocalculating while rephrasing its caption. Now the limit number is set either automatically by GetCalculatedLimit() or not at all if the option is disabled. (Un-)checking the CheckboxLimit in Mainform now toggles this option permanently. 2008-03-24 00:11:38 +00:00
Ansgar Becker
747be5b4ef Code simplification: Replace remaining shabby RegObj.ReadXY() routines with Main.GetRegValue . 2008-03-23 23:20:19 +00:00
Ansgar Becker
56abd6f53d - Fix detection of views in a SHOW TABLE STATUS result. Don't rely on the "Comment" field containing the exact string "VIEW", as it can also contain an error message wrt a corrupted view.
- Show this potential message in the "Comment" column of ListTables
2008-03-23 19:31:04 +00:00
Ansgar Becker
cbb6d3d220 Benefit from childwin's table cache in "Import text file" dialog 2008-03-23 14:01:46 +00:00
Ansgar Becker
f64daf6917 New feature: VIEW editor, can create and edit views. Rather a simple dialog with only the most important options on it. The toolbuttons on mainform are partly moved around, that's the reason for the myriad of changes there. 2008-03-19 21:20:28 +00:00
Ansgar Becker
de12c10721 Refactor Maintenance dialog to fullfill reasonable user wishes in bug #1865477 :
- Rename components with reasonable names
- Use caching mechanism from Childwin.FetchDBTableList to fill tables listbox
- Make form resizable, store and restore customized dimensions
- Keep form instance alive and recycle that instance as long as Mainform lives
- Fix confusion with action item (wasn't really used in both menuitems)
- Add documentation
2008-03-18 20:58:03 +00:00
Ansgar Becker
b815b91039 Fix bug #1865477 "Table maintenance does not show any response"
By removing the (superflous) context menu versions of "Optimize", "Check", "Analyze" and "Repair" table.
2008-03-18 19:54:20 +00:00
Ansgar Becker
e9f18b29bb Fix bug #1879419 "viewing data with tables of the same name" 2008-03-17 21:26:31 +00:00
Ansgar Becker
112ea167a5 Add basic support for views, without changing too much GUI logic:
- Give them their own icon in dbtree and ListTables
- Disable pure table actions (like "Alter table", "Optimize" etc.) in context menus when a view is selected
- Add new column in ListTables: "Type" which is filled either with "Base table" or "View"
- Introduce new property "NodeType" in TVTreeData record, used currently to store NODETYPE_VIEW or NODETYPE_TABLE. This new property is meant to be used for various purposes in other VirtualTrees in the future.
- Introduce Childwin.SelectedTableType, corresponding to Childwin.SelectedTable
- Make DropTable action fit for also dropping views (and surely a list with a mixture of views and tables)
- Don't fetch rowcount from views in DisplayRowCountStats to fix bug #1844952
2008-03-17 20:35:50 +00:00
Ansgar Becker
334311c2ea Make wording in column headers of ListTables up-to-date:
- "Table" => "Name" (can also contain views)
- "Records" => "Rows" (records is old-style)
- "Type" => "Engine" (dito, plus MySQL renamed that also in the SHOW TABLE STATUS result)
2008-03-15 22:40:39 +00:00
Ansgar Becker
14b95f62ec Remove redundant and misleading menu items "Limit" and "Edit Memo/Blob" from popupmenu in datagrid 2008-03-15 10:59:41 +00:00
Ansgar Becker
4c6f342f43 Assign different icons for non-killed processes in ListProcesses:
- Idle: green tick
- Running: blue play icon
2008-03-15 10:52:09 +00:00
Ansgar Becker
01c6552829 Fix/enhance various icon issues:
- Fix wrong imageindexes in quickfilter menus for clipboard inserting and "Drop filter"
- Assign existing, fitting icons to all other quick filter menu items and "Insert date/time" items.
- Replace icon for "Query" tab by the big blue arrow which is also used for the "Play" button
- Replace icon for "View Data" buttons and "Data" tab with a more simplistic one from the Silk set. This makes the normal "table" icon more distinct as these both looked very similar previously.
- Edit the "Import CSV file" icon: add some lines which can be better associated with a "text file"
- Remove "Reload privileges" button on toolbar and leave it in the tools "flush" menu. Also remove confusing icon for this menu item as that was highly similar to the master refresh symbol.
- Assign a different (hopefully clearer) icon to "Export SQL" action
- Add seperator between database and table toolbuttons
2008-03-15 10:45:00 +00:00
Ansgar Becker
5bf8555257 Find a better event for listening to changes in ListColumns: OnStateChange. OnChange sometimes isn't fired when no node is selected. Fixes state of menuEditField which should only be enabled when a node in ListColumns is focused. 2008-03-10 21:40:09 +00:00
Ansgar Becker
dcab2fb099 Disabled icons should be displayed grayscaled, not only blended. Makes it easier to detect the non-disabled icons. 2008-03-10 21:16:38 +00:00
Ansgar Becker
1cc757ba73 Delphi insists on moving these TPngSpeedButtons somewhere else in the DFM files. Properties are all kept, only the positions in the files have changed.
I have a slight feeling that this change fixes at least one access violation in the last nightly builds which I cannot reproduce when I compile these changed files.
2008-03-10 20:24:14 +00:00
Ansgar Becker
9306da23b9 Remove Font properties of controls which have the same font assigned as the parent component but have ParentFont set to False. The effect of this change should be not visible in any form, only in the code of the DFM files.
Related revision: 956.
2008-03-09 21:00:35 +00:00
Ansgar Becker
38caa4cd99 Make most "btnCancelClick" procedures superflous by assigning the correct ModalResult (mrCancel) to the relevant cancel buttons. 2008-03-09 20:27:12 +00:00
Ansgar Becker
9618ac94b3 Fix directory selection in dialog "Export SQL": Root directory was set to previously selected directory which made it impossible to select parent directories of that one. 2008-03-09 20:04:13 +00:00
Ansgar Becker
e53db0a9b7 PngIcons:
- Ban glyph data of all TSpeedButton's + TBitBtn's out of dfm files by converting them to TPngSpeedButtons and assign an image from PngImageListMain at runtime.
- Add "highlight" versions of "database" and "table" icons and use these on selected DBtree nodes.
- Remove no longer used BMP icons

Todo: Fill PngImageListMain at runtime.
Note 1: TBitBtn's are not Windows-theme-aware, even with a manifest in place, so we should avoid using them anywhere.
Note 2: T(Png)SpeedButton lacks a TabOrder property, so some of the other TabOrder's are automatically changed here.
2008-03-09 19:56:52 +00:00
Ansgar Becker
866146d4b7 Usability: An "OK" button should be left besides a "Cancel" button. Fix position of these buttons on the dialog "Edit system variable" to make it consistent with other dialogs. 2008-03-09 08:52:13 +00:00
Ansgar Becker
e29840a616 Fix bug #1842564 "Incorrect table name" after using index editor . Missing begin/end in PopulateTreeTableList. 2008-03-06 19:47:35 +00:00
Ansgar Becker
9d8c33b3ce Fix detection of primary columns in datagrid, was broken since rev 1234. 2008-03-05 12:28:55 +00:00
Ansgar Becker
815eea1481 Rename childwin's "Description" property to "SessionName" which says more exactly what it really is. 2008-03-05 12:21:25 +00:00
Ansgar Becker
1ccb907501 Fix bug #1907061 "Columns selection combobox in DataGrid is not working". GetRegValue needed session name as 3rd parameter. 2008-03-05 11:31:32 +00:00
Ansgar Becker
1edb5b3edc 2nd followup to rev 1234: Accidently forgotten part of commit. Fixes a compiler error. 2008-03-04 00:53:13 +00:00