From f097207afd4afcd5016393c1143e38b99edd0fa0 Mon Sep 17 00:00:00 2001
From: Ansgar Becker <ansgarbecker@users.noreply.github.com>
Date: Sat, 29 Sep 2007 23:27:30 +0000
Subject: [PATCH] Remove redundant buttons/menuitems "Insert Record" from
 Database and Table tab. The functions was buggy and is already fullfilled by
 the button/menuitem "View data" and the Data tab itself.

---
 source/childwin.dfm | 31 -------------------------------
 source/childwin.pas | 14 --------------
 2 files changed, 45 deletions(-)

diff --git a/source/childwin.dfm b/source/childwin.dfm
index bf65c56b..968fd42c 100644
--- a/source/childwin.dfm
+++ b/source/childwin.dfm
@@ -567,15 +567,6 @@ object MDIChild: TMDIChild
               ShowHint = True
               TabOrder = 0
               Transparent = True
-              object btnDbInsertRecord: TToolButton
-                Left = 0
-                Top = 0
-                Hint = 'Insert Record...|Insert new Record into Table...'
-                Caption = 'Insert Record'
-                Enabled = False
-                ImageIndex = 32
-                OnClick = InsertRecord
-              end
             end
           end
         end
@@ -687,15 +678,6 @@ object MDIChild: TMDIChild
               TabOrder = 1
               Transparent = True
               Wrapable = False
-              object btnTableInsertRecord: TToolButton
-                Left = 0
-                Top = 0
-                Hint = 'Insert Record...|Insert new Record into Table...'
-                Caption = 'btnTableInsertRecord'
-                ImageIndex = 32
-                Wrap = True
-                OnClick = InsertRecord
-              end
             end
           end
           object ListColumns: TVirtualStringTree
@@ -1678,13 +1660,6 @@ object MDIChild: TMDIChild
       ImageIndex = 8
       OnClick = MenuViewDataClick
     end
-    object menuinsert: TMenuItem
-      Caption = 'Insert Record'
-      Enabled = False
-      ImageIndex = 32
-      ShortCut = 45
-      OnClick = InsertRecord
-    end
     object InsertfilesintoBLOBfields1: TMenuItem
       Action = MainForm.InsertFiles
     end
@@ -1879,12 +1854,6 @@ object MDIChild: TMDIChild
     object N3: TMenuItem
       Caption = '-'
     end
-    object Insertrecord2: TMenuItem
-      Caption = 'Insert record...'
-      ImageIndex = 32
-      ShortCut = 45
-      OnClick = InsertRecord
-    end
     object InsertfilesintoBLOBfields2: TMenuItem
       Action = MainForm.InsertFiles
     end
diff --git a/source/childwin.pas b/source/childwin.pas
index fc69723a..71a5b23d 100644
--- a/source/childwin.pas
+++ b/source/childwin.pas
@@ -44,7 +44,6 @@ type
     popupDbGrid: TPopupMenu;
     menuviewdata: TMenuItem;
     menuproperties: TMenuItem;
-    menuinsert: TMenuItem;
     menudroptable: TMenuItem;
     menuemptytable: TMenuItem;
     tabHost: TTabSheet;
@@ -78,7 +77,6 @@ type
     PopupmenuDropDatabase: TMenuItem;
     popupDataGrid: TPopupMenu;
     Refresh3: TMenuItem;
-    Insertrecord2: TMenuItem;
     MenuAddField: TMenuItem;
     MenuEditField: TMenuItem;
     popupResultGrid: TPopupMenu;
@@ -278,7 +276,6 @@ type
     PopupMenuCreateTable: TMenuItem;
     pnlDatabaseToolbar: TPanel;
     tlbDataLeft2: TToolBar;
-    btnDbInsertRecord: TToolButton;
     tlbDataLeft1: TToolBar;
     btnDbViewData: TToolButton;
     btnDbProperties: TToolButton;
@@ -292,7 +289,6 @@ type
     btnTableDropField: TToolButton;
     btnTableManageIndexes: TToolButton;
     tlbTableLeft2: TToolBar;
-    btnTableInsertRecord: TToolButton;
     menuSQLhelp: TMenuItem;
     N24: TMenuItem;
     menuSQLhelpData: TMenuItem;
@@ -404,7 +400,6 @@ type
     procedure ClearFilter(Sender: TObject);
     procedure LoadSQLWhereFile(Sender: TObject);
     procedure DropFilter1Click(Sender: TObject);
-    procedure InsertRecord(Sender: TObject);
     procedure selectall1Click(Sender: TObject);
     procedure popupResultGridPopup(Sender: TObject);
     procedure gridDataColumnMoved(Sender: TObject; FromIndex,
@@ -2334,8 +2329,6 @@ begin
   tableSelected := (Length(ListTables.GetSortedSelection(False))>0) and FrmIsFocussed;
   btnDbProperties.Enabled := tableSelected;
   menuproperties.Enabled := tableSelected;
-  btnDbInsertRecord.Enabled := tableSelected;
-  menuinsert.Enabled := tableSelected;
   btnDbViewData.Enabled := tableSelected;
   menuviewdata.Enabled := tableSelected;
   btnDbEmptyTable.Enabled := tableSelected;
@@ -4112,13 +4105,6 @@ begin
 end;
 
 
-procedure TMDIChild.InsertRecord(Sender: TObject);
-begin
-  viewdata(self);
-  GetVisualDataset().Insert;
-end;
-
-
 // select all tables
 procedure TMDIChild.selectall1Click(Sender: TObject);
 begin