opensource/HeidiSQL
1
0
Fork 0
mirror of https://github.com/HeidiSQL/HeidiSQL.git synced 2025-08-26 03:01:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix division by zero crash when SQL server reports an empty string from SELECT SERVERPROPERTY('ProductVersion'). See http://www.heidisql.com/forum.php?t=16369

Browse Source
This commit is contained in:
Ansgar Becker
2014-09-18 15:55:35 +00:00
parent 4f0355ee27
commit dac243ab9e
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
source/dbconnection.pas
View File

@ -1666,7 +1666,7 @@ end;
procedure TAdoDBConnection.SetActive(Value: Boolean);
var
tmpdb, Error, NetLib, DataSource, QuotedPassword: String;
tmpdb, Error, NetLib, DataSource, QuotedPassword, ServerVersion: String;
rx: TRegExpr;
i: Integer;
begin
@ -1745,7 +1745,9 @@ begin
FServerVersionUntouched := rx.Match[1];
try
// Try to get more exact server version to avoid displaying "20.14" in some cases
FServerVersionUntouched := GetVar('SELECT SERVERPROPERTY('+EscapeString('ProductVersion')+')');
ServerVersion := GetVar('SELECT SERVERPROPERTY('+EscapeString('ProductVersion')+')');
if ExecRegExpr('(\d+)\.(\d+)\.(\d+)\.(\d+)', ServerVersion) then
FServerVersionUntouched := ServerVersion;
except
// Above query only works on SQL Server 2008 and newer
// Keep value from SELECT @@VERSION on older servers