From ad71496037d544f84ad76b1338c0082ae8422ee1 Mon Sep 17 00:00:00 2001 From: Ansgar Becker Date: Sun, 5 Nov 2023 10:05:13 +0100 Subject: [PATCH] Warn the user about potential data loss when loading a (csv) file with encoding set to "auto-detect". There are still EEncodingError reports uploaded. --- source/loaddata.pas | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/source/loaddata.pas b/source/loaddata.pas index 846924e6..77fce1d2 100644 --- a/source/loaddata.pas +++ b/source/loaddata.pas @@ -673,6 +673,10 @@ begin editfilename.Text := Dialog.FileName; FFileEncoding := Mainform.GetEncodingByName(Dialog.Encodings[Dialog.EncodingIndex]); if FFileEncoding = nil then begin + MessageDialog(_('Auto detecting the encoding of a file is highly discouraged. You may experience data loss if the detection fails.') + + SLineBreak + SLineBreak + + _('To avoid this message select the correct encoding before pressing Open.'), + mtWarning, [mbOK]); TestStream := TFileStream.Create(Dialog.Filename, fmOpenRead or fmShareDenyNone); FFileEncoding := DetectEncoding(TestStream); TestStream.Free;