opensource/HeidiSQL
1
0
Fork 0
mirror of https://github.com/HeidiSQL/HeidiSQL.git synced 2025-08-26 11:17:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Issue #746: prefer AnsiString over Byte data type for buffering http request result.

Browse Source
This commit is contained in:
Ansgar Becker
2019-09-15 19:08:40 +02:00
parent 56474eaa1b
commit abc9ef16f9
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
source/apphelpers.pas
View File

@ -3214,7 +3214,7 @@ procedure THttpDownload.SendRequest(Filename: String);
var var
NetHandle: HINTERNET; NetHandle: HINTERNET;
UrlHandle: HINTERNET; UrlHandle: HINTERNET;
Buffer: array[1..4096] of Byte; Buffer: array[0..4095] of AnsiChar;
Head: array[1..1024] of Char; Head: array[1..1024] of Char;
BytesInChunk, HeadSize, Reserved, TimeOutSeconds: Cardinal; BytesInChunk, HeadSize, Reserved, TimeOutSeconds: Cardinal;
LocalFile: File; LocalFile: File;
@ -3273,7 +3273,8 @@ begin
if DoStore then begin if DoStore then begin
BlockWrite(LocalFile, Buffer, BytesInChunk) BlockWrite(LocalFile, Buffer, BytesInChunk)
end else begin end else begin
SetString(ContentChunk, PChar(@Buffer[1]), BytesInChunk); SetString(ContentChunk, PChar(@Buffer[0]), BytesInChunk);
//ContentChunk := String(@Buffer[0]);
FLastContent := FLastContent + ContentChunk; FLastContent := FLastContent + ContentChunk;
end; end;
Inc(FBytesRead, BytesInChunk); Inc(FBytesRead, BytesInChunk);