- Move all hardcoded preferences names (registry) plus their default values to const.inc to fix inconsistencies like the one described here: http://www.heidisql.com/forum/viewtopic.php?p=1739

- Consequently use Mainform.GetRegValue() to read these values, an overloaded method with either Boolean, String or Integer result. These methods keep a global TRegistry object (regMain) open while the application runs, rather than creating a new one for each caller.
- Remove Mainform.SaveRegValue() which was used in one or two callers. Rather use a TRegistry object and do that by hand. There's no significant advantage in using a SaveRegValue method currently.
This commit is contained in:
Ansgar Becker
2008-02-06 00:00:52 +00:00
parent be733f6821
commit 4e23728aa2
12 changed files with 599 additions and 740 deletions

View File

@@ -87,12 +87,12 @@ begin
m := Mainform.Childwin;
// Set window-layout
Top := Mainform.GetRegValue( 'SQLHelp_WindowTop', Top );
Left := Mainform.GetRegValue( 'SQLHelp_WindowLeft', Left );
Width := Mainform.GetRegValue( 'SQLHelp_WindowWidth', Width );
Height := Mainform.GetRegValue( 'SQLHelp_WindowHeight', Height );
pnlLeft.Width := Mainform.GetRegValue( 'SQLHelp_PnlLeftWidth', pnlLeft.Width );
pnlRightTop.Height := Mainform.GetRegValue( 'SQLHelp_PnlRightTopHeight', pnlRightTop.Height );
Top := Mainform.GetRegValue( REGNAME_SQLHELPWINTOP, Top );
Left := Mainform.GetRegValue( REGNAME_SQLHELPWINLEFT, Left );
Width := Mainform.GetRegValue( REGNAME_SQLHELPWINWIDTH, Width );
Height := Mainform.GetRegValue( REGNAME_SQLHELPWINHEIGHT, Height );
pnlLeft.Width := Mainform.GetRegValue( REGNAME_SQLHELPPLWIDTH, pnlLeft.Width );
pnlRightTop.Height := Mainform.GetRegValue( REGNAME_SQLHELPPRHEIGHT, pnlRightTop.Height );
Caption := DEFAULT_WINDOW_CAPTION;
MemoDescription.Font.Name := m.SynMemoQuery.Font.Name;
@@ -308,14 +308,20 @@ end;
Save layout and close window
}
procedure TfrmSQLhelp.ButtonCloseClick(Sender: TObject);
var
reg : TRegistry;
begin
Mainform.SaveRegValue( 'SQLHelp_WindowLeft', Left );
Mainform.SaveRegValue( 'SQLHelp_WindowTop', Top );
Mainform.SaveRegValue( 'SQLHelp_WindowWidth', Width );
Mainform.SaveRegValue( 'SQLHelp_WindowHeight', Height );
Mainform.SaveRegValue( 'SQLHelp_PnlLeftWidth', pnlLeft.Width );
Mainform.SaveRegValue( 'SQLHelp_PnlRightTopHeight', PnlRightTop.Height );
reg := TRegistry.Create;
if reg.OpenKey(REGPATH, False) then begin
reg.WriteInteger( REGNAME_SQLHELPWINLEFT, Left );
reg.WriteInteger( REGNAME_SQLHELPWINTOP, Top );
reg.WriteInteger( REGNAME_SQLHELPWINWIDTH, Width );
reg.WriteInteger( REGNAME_SQLHELPWINHEIGHT, Height );
reg.WriteInteger( REGNAME_SQLHELPPLWIDTH, pnlLeft.Width );
reg.WriteInteger( REGNAME_SQLHELPPRHEIGHT, PnlRightTop.Height );
reg.CloseKey;
end;
reg.Free;
Close;
end;