opensource/HeidiSQL
1
0
Fork 0
mirror of https://github.com/HeidiSQL/HeidiSQL.git synced 2025-08-26 03:01:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Do not fetch database objects from information_schema, which has gotten extremely slow on servers with many databases and triggers, since we support triggers.

Browse Source 
* Instead, use separate SHOW commands for tables, functions, procedures and triggers
* Catch this chance to move these methods from main unit to mysql_connection, so they're accessible in a more generic way
* Additionally, introduce new classes TDBObject and TDBObjectList which provide a more generic way than TMySQLQuery to access these database objects.
Fixes issue #1529
This commit is contained in:
Ansgar Becker
2009-12-19 11:40:28 +00:00
parent dfa981232c
commit 35e8bbb304
12 changed files with 509 additions and 536 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
source/helpers.pas
View File

@ -15,8 +15,6 @@ uses Classes, SysUtils, Graphics, GraphUtil, db, clipbrd, dialogs,
type
TListNodeType = (lntNone, lntDb, lntTable, lntCrashedTable, lntView, lntFunction, lntProcedure, lntTrigger, lntColumn);
TListNodeTypes = Set of TListNodeType;
TListNode = record
Text: WideString;
NodeType: TListNodeType;
@ -212,7 +210,6 @@ type
function GetVTCaptions( VT: TVirtualStringTree; OnlySelected: Boolean = False; Column: Integer = 0; OnlyNodeTypes: TListNodeTypes = [lntNone] ): TWideStringList;
procedure SetVTSelection( VT: TVirtualStringTree; Selected: TWideStringList );
function GetTempDir: String;
function GetDBObjectType(TableStatus: TMySQLQuery): TListNodeType;
procedure SetWindowSizeGrip(hWnd: HWND; Enable: boolean);
procedure SaveUnicodeFile(Filename: String; Text: WideString);
procedure OpenTextFile(const Filename: String; out Stream: TFileStream; out FileCharset: TFileCharset);
@ -240,7 +237,6 @@ type
procedure SelectNode(VT: TVirtualStringTree; Node: PVirtualNode); overload;
function DateBackFriendlyCaption(d: TDateTime): String;
procedure InheritFont(AFont: TFont);
function GetTableSize(Results: TMySQLQuery): Int64;
function GetLightness(AColor: TColor): Byte;
procedure ParseTableStructure(CreateTable: WideString; Columns: TObjectList=nil; Keys: TObjectList=nil; ForeignKeys: TObjectList=nil);
procedure ParseViewStructure(ViewName: WideString; Columns: TObjectList);
@ -2186,47 +2182,6 @@ begin
end;
// Tell type of db object (table|view) by a given row from a SHOW TABLE STATUS result
function GetDBObjectType(TableStatus: TMySQLQuery): TListNodeType;
var
t: String;
begin
{**
@see http://dev.mysql.com/doc/refman/5.1/en/show-table-status.html
For views, all the fields displayed by SHOW TABLE STATUS are NULL except
that Name indicates the view name and Comment says view.
@note The "Comment" column can contain different content, normally "VIEW"
but for views which is missing its tables, it says
"Views bla references invalid..."
}
Result := lntTable;
if TableStatus.ColExists('Type') then begin
t := TableStatus.Col('Type');
if t = 'BASE TABLE' then
Result := lntTable
else if t = 'VIEW' then
Result := lntView
else if t = 'FUNCTION' then
Result := lntFunction
else if t = 'PROCEDURE' then
Result := lntProcedure
else if t = 'TRIGGER' then
Result := lntTrigger;
end else begin
if
TableStatus.IsNull(1) and // Engine column is NULL for views
TableStatus.IsNull(2) and
(Pos('VIEW', UpperCase(TableStatus.Col(DBO_COMMENT))) > 0)
then Result := lntView;
if
TableStatus.IsNull(1) and
TableStatus.IsNull(2) and
(Pos('MARKED AS CRASHED', UpperCase(TableStatus.Col(DBO_COMMENT))) > 0)
then Result := lntCrashedTable;
end;
end;
{
Code taken from SizeGripHWND.pas:
Copyright (C) 2005, 2006 Volker Siebert <flocke@vssd.de>
@ -2928,17 +2883,6 @@ begin
end;
function GetTableSize(Results: TMySQLQuery): Int64;
var
d, i: String;
begin
d := Results.Col('Data_length', True);
i := Results.Col('Index_length', True);
if (d = '') or (i = '') then Result := -1
else Result := MakeInt(d) + MakeInt(i);
end;
function GetLightness(AColor: TColor): Byte;
var
R, G, B: Byte;