opensource/HeidiSQL
1
0
Fork 0
mirror of https://github.com/HeidiSQL/HeidiSQL.git synced 2025-08-06 18:24:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

Performance fix: EnsureChunkLoaded should be called in a node, not cell context (which is way too often)

Browse Source
This commit is contained in:
Ansgar Becker
2009-02-16 19:51:33 +00:00
parent c726dddd4a
commit 26a5713c27
1 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
source/helpers.pas
View File

@ -856,13 +856,13 @@ begin
if (Node.Index+1) mod 100 = 0 then
ExportStatusMsg(Node, Grid.RootNodeCount, S.Size);
tmp := ' <tr>' + CRLF;
// Add cells.
// Ensure basic data is loaded
Mainform.EnsureChunkLoaded(Grid, Node);
for i:=0 to Length(GridData.Columns) - 1 do begin
// Skip hidden key columns
if not (coVisible in Grid.Header.Columns[i].Options) then
Continue;
// Ensure basic data is loaded and load remainder of large fields.
Mainform.EnsureChunkLoaded(Grid, Node);
// Load remainder of large fields.
Mainform.EnsureFullWidth(Grid, i, Node);
Data := Grid.Text[Node, i];
// Handle nulls.
@ -949,12 +949,13 @@ begin
if (Node.Index+1) mod 100 = 0 then
ExportStatusMsg(Node, Grid.RootNodeCount, S.Size);
tmp := '';
// Ensure basic data is loaded
Mainform.EnsureChunkLoaded(Grid, Node);
for i:=0 to Grid.Header.Columns.Count-1 do begin
// Skip hidden key columns
if not (coVisible in Grid.Header.Columns[i].Options) then
Continue;
// Ensure basic data is loaded and load remainder of large fields.
Mainform.EnsureChunkLoaded(Grid, Node);
// Load remainder of large fields.
Mainform.EnsureFullWidth(Grid, i, Node);
Data := Grid.Text[Node, i];
// Remove 0x.
@ -1018,15 +1019,14 @@ begin
if (Node.Index+1) mod 100 = 0 then
ExportStatusMsg(Node, Grid.RootNodeCount, S.Size);
tmp := #9'<row>' + CRLF;
// Data:
// Ensure basic data is loaded.
Mainform.EnsureChunkLoaded(Grid, Node);
for i:=0 to Grid.Header.Columns.Count-1 do begin
// Skip hidden key columns
if not (coVisible in Grid.Header.Columns[i].Options) then
Continue;
// Print cell start tag.
tmp := tmp + #9#9'<' + Grid.Header.Columns[i].Text;
// Ensure basic data is loaded.
Mainform.EnsureChunkLoaded(Grid, Node);
if GridData.Rows[Node.Index].Cells[i].IsNull then tmp := tmp + ' isnull="true" />' + CRLF
else begin
if GridData.Columns[i].IsBinary then tmp := tmp + ' format="hex"';
@ -1098,13 +1098,12 @@ begin
end;
Delete(tmp, Length(tmp)-1, 2);
tmp := tmp + ') VALUES (';
// Data:
// Ensure basic data is loaded.
Mainform.EnsureChunkLoaded(Grid, Node);
for i:=0 to Grid.Header.Columns.Count-1 do begin
// Skip hidden key columns
if not (coVisible in Grid.Header.Columns[i].Options) then
Continue;
// Ensure basic data is loaded.
Mainform.EnsureChunkLoaded(Grid, Node);
if GridData.Rows[Node.Index].Cells[i].IsNull then
tmp := tmp + 'NULL'
else begin