opensource/HeidiSQL
1
0
Fork 0
mirror of https://github.com/HeidiSQL/HeidiSQL.git synced 2025-08-26 20:50:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Minor performance tweak: cache data types of all columns once at execution time in TMySQLQuery. Only noticeable in places where we heavily check data types.

Browse Source
This commit is contained in:
Ansgar Becker
2009-11-12 21:48:49 +00:00
parent 5b6c94e8f7
commit 22c15198da
1 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
source/mysql_connection.pas
View File

@ -143,6 +143,7 @@ type
FLastResult: PMYSQL_RES;
FCurrentRow: PMYSQL_ROW;
FEof: Boolean;
FDatatypes: Array of TDatatype;
procedure SetSQL(Value: WideString);
procedure SetRecNo(Value: Int64);
public
@ -648,18 +649,29 @@ end;
procedure TMySQLQuery.Execute;
var
i: Integer;
i, j, NumFields: Integer;
Field: PMYSQL_FIELD;
begin
FLastResult := Connection.Query(FSQL, True);
FRecordCount := Connection.RowsFound;
if HasResult then begin
for i:=0 to mysql_num_fields(FLastResult)-1 do begin
NumFields := mysql_num_fields(FLastResult);
SetLength(FDatatypes, NumFields);
for i:=0 to NumFields-1 do begin
Field := mysql_fetch_field_direct(FLastResult, i);
FColumnNames.Add(Utf8Decode(Field.name));
FDatatypes[i] := Datatypes[Low(Datatypes)];
for j:=Low(Datatypes) to High(Datatypes) do begin
if Field._type = Datatypes[j].NativeType then begin
FDatatypes[i] := Datatypes[j];
break;
end;
end;
end;
RecNo := 0;
end;
end else
SetLength(FDatatypes, 0);
end;
@ -718,18 +730,8 @@ end;
function TMySQLQuery.DataType(Column: Integer): TDataType;
var
i: Integer;
Field: PMYSQL_FIELD;
begin
Field := mysql_fetch_field_direct(FLastResult, Column);
Result := Datatypes[Low(Datatypes)];
for i:=Low(Datatypes) to High(Datatypes) do begin
if Field._type = Datatypes[i].NativeType then begin
Result := Datatypes[i];
break;
end;
end;
Result := FDatatypes[Column];
end;