From cb7b962a4addabc441189b35703a3ef62d687212 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Sat, 8 Nov 2025 00:52:03 +0100 Subject: [PATCH] avutil/timecode: Fix -Wformat-truncation warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Using unsigned for fps is more natural since the corresponding AVTimecode field is unsigned. It also fixes a -Wformat-truncation warning from GCC 16: in case fps were negative, hours, minutes and seconds would be negative, leading to additional '-' characters which are not accounted for in AV_TIMECODE_STR_SIZE. Reviewed-by: Kacper Michajłow Signed-off-by: Andreas Rheinhardt --- libavutil/timecode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/timecode.c b/libavutil/timecode.c index bca16b6ac2..b5352a3961 100644 --- a/libavutil/timecode.c +++ b/libavutil/timecode.c @@ -103,7 +103,7 @@ uint32_t av_timecode_get_smpte(AVRational rate, int drop, int hh, int mm, int ss char *av_timecode_make_string(const AVTimecode *tc, char *buf, int framenum_arg) { - int fps = tc->fps; + unsigned fps = tc->fps; int drop = tc->flags & AV_TIMECODE_FLAG_DROPFRAME; int hh, mm, ss, ff, ff_len, neg = 0; int64_t framenum = framenum_arg;