opensource/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-06-28 20:14:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

apedec: fix signed integer overflows

Browse Source 
This bit manipulation is equivalent but avoids undefined
shifts and overflows.

Signed-off-by: Mans Rullgard <mans@mansr.com>
This commit is contained in:
Mans Rullgard
2011-11-25 18:46:35 +00:00
parent 93c286e54f
commit 644bff6c9b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libavcodec/apedec.c
View File

@ -690,7 +690,7 @@ static void do_apply_filter(APEContext *ctx, int version, APEFilter *f,
/* Update the adaption coefficients */ /* Update the adaption coefficients */
absres = FFABS(res); absres = FFABS(res);
if (absres) if (absres)
*f->adaptcoeffs = ((res & (1<<31)) - (1<<30)) >> *f->adaptcoeffs = ((res & (-1<<31)) ^ (-1<<30)) >>
(25 + (absres <= f->avg*3) + (absres <= f->avg*4/3)); (25 + (absres <= f->avg*3) + (absres <= f->avg*4/3));
else else
*f->adaptcoeffs = 0; *f->adaptcoeffs = 0;